Problem of displaying and editing lg templates in generated Form Dialog

[yeze322]

Describe the bug

Found several problems related to LG displaying and editing a generated dialog in Composer, especially related to the $kind SendActivity.

1. SendActivity node is empty in Flow Editor

Problem:

Causes:

It's a bug of the SendActivity node, when the lg template can't be found, it should fallback to the raw value instead of showing nothing.

Suggested solution:

It can be fixed by a one-line change

2. Form Editor shows the template name instead of the exact content

Problem:

Causes

By design in Composer.

Suggested solution:

Needs furthur discussion.

• Should we dereference the lg template?
• If so, how do we show those templates with parameters filled?
• Or we just keep the current behavior and let users edit the referenced content in all up view?

3. Neither Form Editor can edit the LG content nor the LG all up view page.

Problem:

1. Form Editor not editable
   
2. LG all up view doesn't show lg templates in imported files.

It leads to these templates not editable in entire Composer.

Suggested solutions:

The problem of Form Editor is caused by the generated dialog doesn't include the $designer.id field.
Composer relies on the $designer.id field to associate *.dialog with *.lg files, it makes sure the lg editor work and Action deletion will always clear related lg template.

To fix that, we have several solutions

1. Let Form Dialog cli follow the $designer.id convention, generate $designer.id when generating dialog.
2. Update Composer logic to be compatible with the case where $designer.id is absent. We can assigning a designer id only to the modified part.

Version

Browser

• Electron distribution
• Chrome
• Safari
• Firefox
• Edge

OS

• macOS
• Windows
• Ubuntu

To Reproduce

Steps to reproduce the behavior:

1. Create a Form schema, add a property, click on 'generate dialog'
2. Go to design page, open the - Help() Trigger
3. Problem 1: nothing shows in the Action card
4. Problem 2: editing the LG content in Form Editor won't take effect

Expected behavior

Screenshots

Additional context