Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Micronaut Framework 3.9.1 #1267

Merged
merged 13 commits into from
May 4, 2023
Merged

build: Micronaut Framework 3.9.1 #1267

merged 13 commits into from
May 4, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 18, 2023

No description provided.

@timyates
Copy link
Contributor

timyates commented May 3, 2023

I think this is due to micronaut-projects/micronaut-starter#1636 I need to dig in...

@sdelamo
Copy link
Contributor Author

sdelamo commented May 3, 2023

@timyates can you check micronautCloudTraceGoogle? It fails.

@timyates
Copy link
Contributor

timyates commented May 4, 2023 •
edited
Loading

@sdelamo tracing guide was broken by micronaut-tracing 4.5.0 which contains

micronaut-projects/micronaut-tracing@598e161#diff-c5a64512cbe71367881cbad055e952e68307bf2cc8ec7fadc9366dc9eb2f65fe

It's a breaking change, as the package names for @SpanAttribute and @WithSpan have changed from

import io.opentelemetry.extension.annotations.SpanAttribute;
import io.opentelemetry.extension.annotations.WithSpan;

to

import io.opentelemetry.instrumentation.annotations.SpanAttribute;
import io.opentelemetry.instrumentation.annotations.WithSpan;

And we use these in the guide source

@sdelamo
Copy link
Contributor Author

sdelamo commented May 4, 2023

@sdelamo tracing guide was broken by micronaut-tracing 4.5.0 which contains

micronaut-projects/micronaut-tracing@598e161#diff-c5a64512cbe71367881cbad055e952e68307bf2cc8ec7fadc9366dc9eb2f65fe

It's a breaking change, as the package names for @SpanAttribute and @WithSpan have changed from

import io.opentelemetry.extension.annotations.SpanAttribute;
import io.opentelemetry.extension.annotations.WithSpan;

to

import io.opentelemetry.instrumentation.annotations.SpanAttribute;
import io.opentelemetry.instrumentation.annotations.WithSpan;

And we use these in the guide source

Please, update the guide for now and create an issue in tracing module about the breaking change

@timyates timyates mentioned this pull request May 4, 2023
Open
@timyates timyates changed the title build: Micronaut Framework 3.9.0 build: Micronaut Framework 3.9.1 May 4, 2023
@sdelamo sdelamo merged commit 146a666 into master May 4, 2023
@sdelamo sdelamo deleted the sdelamo-patch-2 branch May 4, 2023 15:41
sdelamo added a commit that referenced this pull request May 24, 2023
@n0tl3ss @timyates
@sbodvanski @sdelamo @wetted @burtbeckwith @graemerocher @alina-yur @hartraft @phamtienlong19
Draft guide for OCI Kubernetes (#1175)
d438c6c 
* Switch to use Serde for the S3 Event guide (#1138)

* Switch to use Serde for the Discovery eureka guide (#1134)

* Switch to use Serde for the Oauth client credentials auth0 guide (#1133)

* Switch to use Serde for the Discovery consul guide (#1135)

* Use the correct version for the micronaut-data processor with SpringBoot (#1164)

We were using the version of Micronaut, which is incorrect

* Guide: Connect a Micronaut JMS Application to an AWS SQS Queue (#1160)

Max supported Java version by AWS SDK 1.x is 16 (https://github.com/aws/aws-sdk-java#maintenance-and-support-for-java-versions)

* add AWS SQS twitter card

* Remove references to postgres and use mysql consistently for guide (#1166)

closes #1161

* Switch to use Serde for the Mybatis data access guide (#1139)

* Switch to use Serde for the Mybatis data access guide

* Remove Creator, fix Kotlin warning

* Fixes missing section in trace guide (#1173)

* Fixes wrong callouts to WarehouseController endpoints (#1174)

* Draft guide for OCI Kubernetes

* Apply suggestions from code review

Co-authored-by: Bernard Horan <bernard.horan@oracle.com>

* Update guides to 3.7.5 (#1179)

* code review improvements add native image support

* code review improvements add native image support

* code review improvements

* code review improvements

* Build Guides with Micronaut 3.8.0 (#1157)

* Build Guides with Micronaut 3.8.0

This PR runs the guides with Micronaut 3.8.0-SNAPSHOT as a pre-release check

Removes the local localstack feature as this now exists in 3.8.0

* Add snapshot repo for snapshot versions of Micronaut

* Look up the version for the data processor

* version 3.8.0

Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>

* Remove ambiguity for Kotlin (#1182)

It couldn't work out which mathod to call as the closure had an implicit return value.

I'm not sure why this has only recently appeared...  Maybe a change to micrometer

* Fix inputs for guides with a base (#1183)

If we have a guide that declares a base project, ie:

https://github.com/micronaut-projects/micronaut-guides/blob/dd911994e0c54c068602389dbcbe08eac8bdf045/guides/micronaut-metrics-aws/metadata.json#L2

Then we were not taking the code from micronaut-metrics into account for the cache-key, so changes were not picked up when building micronaut-metrics-aws

This change adds the base directory as an input if it was set

* remove empty constructor (#1167)

* misc fixes and cleanup (#1186)

* Add R2DBC guide (#965)

* copy: change GraalVM version (#1187)

* change publication to 2023-01-04

* fix: category should be categories

* disable spring-boot-micronaut-data guide (#1185)

* Micronaut Framework 3.8.1 (#1195)

* Kotlin and Groovy versions of Micronaut Dependency Injection types (#1227)

Close #1082

* Add K8s AWS guide

* Add K8s AWS guide

* Kotlin version of JAX-RS guide (#1225)

Close #1221

* code review improvements

* Micronaut Framework 3.8.2 (#1229)

* fix java version typo (#1234)

* Mock Github Server to avoid rate limiting in HTTP Client Guide (#1236)

* build: Micronaut Framework 3.8.4

* X-API-KEY guide (#1237)

* add api key guide twitter card

* CORS guide (#1238)

* docker image guide (#1239)

* executable Jar guide to distribution category (#1240)

- enable every language. Use distributable-base

* create the http client lazyly (#1243)

* add lateinit and @field callouts (#1228)

* Custom constraint guide (#1244)

* custom constraint

* Update guides/micronaut-custom-validation-annotation/java/src/test/java/example/micronaut/ContactTest.java

* twitter card

* Fix curl command (#1248)

When copying the curl command, each new line is executed rather than waiting for the last command.

* build: Micronaut Framework 3.8.5(#1249)

* Guide: Using IntelliJ IDEA to develop Micronaut applications (#1241)

* 2023 copyright

* Micronaut Framework 3.8.6 (#1251)

* build: Micronaut Framework 3.8.7 (#1252)

* add awaitility version (#1253)

Close: #1074

* Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. (#1254)

* [Error-handling Guide] Added missing dependency and a closing bracket for the BookController class. (#1260)

* Micronaut Framework 3.8.8 (#1261)

* move create your first graalvm guide to distribution category (#1256)

* Security Session Guide: Removed the extra dependency that could cause tests to fail (#1263)

* CRaC Cloud Run guide (#1259)

Close #1257

* Keycloak Guide (#586)

* add back common-google-cloud-platform.adoc snippet

accidentally deleted via #1259

* add image back

* use categories

* Micronaut Framework 3.8.9 (#1264)

* [Database JDBC Guides for AWS, Azure, and GCP] Fixed the environment variable names to be compatible with the sample JDBC application, and added explanations similar to the original JDBC guide. (#1270)

* build: Micronaut Framework 3.9.1 (#1267)

* build: Micronaut Build Plugin to 5.4.9 (#1273)

* 3.9.2 (#1280)

---------

Co-authored-by: Tim Yates <tim.yates@gmail.com>
Co-authored-by: Slavko <bodvanski.slavko@gmail.com>
Co-authored-by: sdelamo <sergio.delamo@softamo.com>
Co-authored-by: Dean Wette <wetted@objectcomputing.com>
Co-authored-by: Bernard Horan <bernard.horan@oracle.com>
Co-authored-by: Burt Beckwith <burt@burtbeckwith.com>
Co-authored-by: Graeme Rocher <graeme.rocher@gmail.com>
Co-authored-by: Alina Yurenko <alina.yurenko@oracle.com>
Co-authored-by: hartraft <hartraft@tutanota.com>
Co-authored-by: Long Pham <ptlitmipitu@gmail.com>
AndreaLaGrotteria pushed a commit to AndreaLaGrotteria/micronaut-guides that referenced this pull request Oct 3, 2024
@sdelamo
build: Micronaut Framework 3.9.1 (micronaut-projects#1267)
1e1d9e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.9.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @timyates