Rework how the dependency coordinates found in templates are handled #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a pom.xml file, this now makes use of a Gradle version catalog, found in `gradle/templates.versions.toml`. This file should be handled by renovatebot automatically. This will typically make the Gradle plugin upgrades much easier to handle since there will be a single place to change. Fixes #1635
|
I believe there's a fix in the pipeline from @sdelamo for the aws/groovy failures |
|
This could be updated to Gradle plugin 3.7.4 but given the very slow feedback loop, I won't push this today. |
sdelamo
requested changes
Mar 2, 2023
There was a problem hiding this comment.
Please, note that we also use the pom.xml in guides. https://github.com/micronaut-projects/micronaut-guides/blob/master/buildSrc/src/main/resources/pom.xml
I assume this is compatible to have another version catalogue in guides.
...st/groovy/io/micronaut/starter/feature/dependencies/MultipleSourcesDependencyResolver.groovy
Show resolved
Hide resolved
starter-core/src/test/groovy/io/micronaut/starter/build/dependencies/PomCoordinatesUtils.java
Outdated
Show resolved
Hide resolved
Oh, so you mean the |
This class is used in `micronaut-guides`, where something similar to this PR could be done.
sdelamo
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a pom.xml file, this now makes use of a Gradle version catalog, found in
gradle/templates.versions.toml. This file should be handled by renovatebot automatically.This will typically make the Gradle plugin upgrades much easier to handle since there will be a single place to change.
Fixes #1635