Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. #1254

phamtienlong19 · 2023-03-14T04:49:39Z

No description provided.

…ure that the Tests work as intended.

CLAassistant · 2023-03-14T04:49:45Z

All committers have signed the CLA.

phamtienlong19 · 2023-03-14T05:00:26Z

Changes in the ScopeTests as well as in the AsciiDoc. Also added the introduction section for further clarity and a section to add junit dependency to the project

Micronaut Scope Types.pdf

sdelamo · 2023-03-15T10:45:13Z

guides/micronaut-scope-types/micronaut-scope-types.adoc

@@ -47,9 +48,13 @@ callout:singleton[1]

 === Singleton Test

+To use the testing features described in this section, add the following dependency to your build file:


Please, move this to a common: snippet.

Just did, please review again, thanks

sdelamo · 2023-03-16T08:27:09Z

guides/micronaut-scope-types/micronaut-scope-types.adoc

-To use the testing features described in this section, add the following dependency to your build file:
-
-dependency:junit-jupiter-params[groupId=org.junit.jupiter,scope=testImplementation]
+common:scopetypes-test.adoc[]


can you rename the common snippets to something like common-junit-params.adoc so that it is easy to spot and reuse in other guides. ?

Just did, please review again, thanks

* Switch to use Serde for the S3 Event guide (#1138) * Switch to use Serde for the Discovery eureka guide (#1134) * Switch to use Serde for the Oauth client credentials auth0 guide (#1133) * Switch to use Serde for the Discovery consul guide (#1135) * Use the correct version for the micronaut-data processor with SpringBoot (#1164) We were using the version of Micronaut, which is incorrect * Guide: Connect a Micronaut JMS Application to an AWS SQS Queue (#1160) Max supported Java version by AWS SDK 1.x is 16 (https://github.com/aws/aws-sdk-java#maintenance-and-support-for-java-versions) * add AWS SQS twitter card * Remove references to postgres and use mysql consistently for guide (#1166) closes #1161 * Switch to use Serde for the Mybatis data access guide (#1139) * Switch to use Serde for the Mybatis data access guide * Remove Creator, fix Kotlin warning * Fixes missing section in trace guide (#1173) * Fixes wrong callouts to WarehouseController endpoints (#1174) * Draft guide for OCI Kubernetes * Apply suggestions from code review Co-authored-by: Bernard Horan <bernard.horan@oracle.com> * Update guides to 3.7.5 (#1179) * code review improvements add native image support * code review improvements add native image support * code review improvements * code review improvements * Build Guides with Micronaut 3.8.0 (#1157) * Build Guides with Micronaut 3.8.0 This PR runs the guides with Micronaut 3.8.0-SNAPSHOT as a pre-release check Removes the local localstack feature as this now exists in 3.8.0 * Add snapshot repo for snapshot versions of Micronaut * Look up the version for the data processor * version 3.8.0 Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com> * Remove ambiguity for Kotlin (#1182) It couldn't work out which mathod to call as the closure had an implicit return value. I'm not sure why this has only recently appeared... Maybe a change to micrometer * Fix inputs for guides with a base (#1183) If we have a guide that declares a base project, ie: https://github.com/micronaut-projects/micronaut-guides/blob/dd911994e0c54c068602389dbcbe08eac8bdf045/guides/micronaut-metrics-aws/metadata.json#L2 Then we were not taking the code from micronaut-metrics into account for the cache-key, so changes were not picked up when building micronaut-metrics-aws This change adds the base directory as an input if it was set * remove empty constructor (#1167) * misc fixes and cleanup (#1186) * Add R2DBC guide (#965) * copy: change GraalVM version (#1187) * change publication to 2023-01-04 * fix: category should be categories * disable spring-boot-micronaut-data guide (#1185) * Micronaut Framework 3.8.1 (#1195) * Kotlin and Groovy versions of Micronaut Dependency Injection types (#1227) Close #1082 * Add K8s AWS guide * Add K8s AWS guide * Kotlin version of JAX-RS guide (#1225) Close #1221 * code review improvements * Micronaut Framework 3.8.2 (#1229) * fix java version typo (#1234) * Mock Github Server to avoid rate limiting in HTTP Client Guide (#1236) * build: Micronaut Framework 3.8.4 * X-API-KEY guide (#1237) * add api key guide twitter card * CORS guide (#1238) * docker image guide (#1239) * executable Jar guide to distribution category (#1240) - enable every language. Use distributable-base * create the http client lazyly (#1243) * add lateinit and @field callouts (#1228) * Custom constraint guide (#1244) * custom constraint * Update guides/micronaut-custom-validation-annotation/java/src/test/java/example/micronaut/ContactTest.java * twitter card * Fix curl command (#1248) When copying the curl command, each new line is executed rather than waiting for the last command. * build: Micronaut Framework 3.8.5(#1249) * Guide: Using IntelliJ IDEA to develop Micronaut applications (#1241) * 2023 copyright * Micronaut Framework 3.8.6 (#1251) * build: Micronaut Framework 3.8.7 (#1252) * add awaitility version (#1253) Close: #1074 * Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. (#1254) * [Error-handling Guide] Added missing dependency and a closing bracket for the BookController class. (#1260) * Micronaut Framework 3.8.8 (#1261) * move create your first graalvm guide to distribution category (#1256) * Security Session Guide: Removed the extra dependency that could cause tests to fail (#1263) * CRaC Cloud Run guide (#1259) Close #1257 * Keycloak Guide (#586) * add back common-google-cloud-platform.adoc snippet accidentally deleted via #1259 * add image back * use categories * Micronaut Framework 3.8.9 (#1264) * [Database JDBC Guides for AWS, Azure, and GCP] Fixed the environment variable names to be compatible with the sample JDBC application, and added explanations similar to the original JDBC guide. (#1270) * build: Micronaut Framework 3.9.1 (#1267) * build: Micronaut Build Plugin to 5.4.9 (#1273) * 3.9.2 (#1280) --------- Co-authored-by: Tim Yates <tim.yates@gmail.com> Co-authored-by: Slavko <bodvanski.slavko@gmail.com> Co-authored-by: sdelamo <sergio.delamo@softamo.com> Co-authored-by: Dean Wette <wetted@objectcomputing.com> Co-authored-by: Bernard Horan <bernard.horan@oracle.com> Co-authored-by: Burt Beckwith <burt@burtbeckwith.com> Co-authored-by: Graeme Rocher <graeme.rocher@gmail.com> Co-authored-by: Alina Yurenko <alina.yurenko@oracle.com> Co-authored-by: hartraft <hartraft@tutanota.com> Co-authored-by: Long Pham <ptlitmipitu@gmail.com>

…ure that the Tests work as intended. (micronaut-projects#1254)

Fixes for MN Scope Types guide, mostly imports and annotations to ens…

37713ac

…ure that the Tests work as intended.

burtbeckwith requested a review from sdelamo March 14, 2023 12:59

sdelamo requested changes Mar 15, 2023

View reviewed changes

Added the test dependency code in Scope Types guide to common-snippet

8f58c17

sdelamo requested changes Mar 16, 2023

View reviewed changes

Renamed the snippet to junit-params

1fe2dc9

sdelamo approved these changes Mar 16, 2023

View reviewed changes

sdelamo merged commit 62e6e74 into micronaut-projects:master Mar 16, 2023

AndreaLaGrotteria pushed a commit to AndreaLaGrotteria/micronaut-guides that referenced this pull request Oct 3, 2024

Fixes for MN Scope Types guide, mostly imports and annotations to ens…

3356691

…ure that the Tests work as intended. (micronaut-projects#1254)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. #1254

Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. #1254

phamtienlong19 commented Mar 14, 2023

CLAassistant commented Mar 14, 2023 •

edited

Loading

phamtienlong19 commented Mar 14, 2023 •

edited

Loading

sdelamo Mar 15, 2023

phamtienlong19 Mar 15, 2023

sdelamo Mar 16, 2023

phamtienlong19 Mar 16, 2023

		@@ -47,9 +48,13 @@ callout:singleton[1]

		=== Singleton Test

		To use the testing features described in this section, add the following dependency to your build file:

Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. #1254

Fixes for MN Scope Types guide, mostly imports and annotations to ensure that the Tests work as intended. #1254

Conversation

phamtienlong19 commented Mar 14, 2023

CLAassistant commented Mar 14, 2023 • edited Loading

phamtienlong19 commented Mar 14, 2023 • edited Loading

sdelamo Mar 15, 2023

Choose a reason for hiding this comment

phamtienlong19 Mar 15, 2023

Choose a reason for hiding this comment

sdelamo Mar 16, 2023

Choose a reason for hiding this comment

phamtienlong19 Mar 16, 2023

Choose a reason for hiding this comment

CLAassistant commented Mar 14, 2023 •

edited

Loading

phamtienlong19 commented Mar 14, 2023 •

edited

Loading