-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter for support blocks filled only with false #6809
Conversation
This comment has been minimized.
This comment has been minimized.
Marking as "not ready" since we need to fix our data first. |
8d2f8a5
to
61c8eeb
Compare
Could this be tweaked to test for falsy values to include null? That's the lint I think we should have :) |
We had way too many |
That's a kind of progress! Would you mind updating what would still be failing this lint now? (I could, but am on phone but still curious...) |
Already did 😉 (I mean, #6854) |
Latest update. |
Nice, a lot more bad data to sort through :) |
ffae018
to
c566ebf
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
Hey @saschanaz, would you be down to update this? We've decided to proceed with disallowing all-false features in BCD! |
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
This pull request has merge conflicts that must be resolved before it can be merged. |
Found #16429 merged first with kinda similar purpose. Not sure what should I do, should I merge this with that one? This one seems to cover more things, at least. @queengooborg |
Okay, found #17743. Can you please ping me before such decision. |
Not sure how should I feel with this. |
A checklist to help your pull request get merged faster:
This implements a linter to prevent any support block filled only with
false
.Quite a lot of failures, not sure how to proceed. Maybe create an allowlist for now and try reducing it later?