Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebRTC APIs that has never been supported #10582

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented May 22, 2021

Summary

Splitted from #6854 and covers only WebRTC changes. @foolip

Test results and supporting details

Related issues

#6809

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 22, 2021
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request May 22, 2021
},
"getSupportedAlgorithms": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCCertificate/getSupportedAlgorithms",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 404 👍

@@ -143,54 +143,6 @@
"deprecated": false
}
}
},
"getSupportedAlgorithms": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/RTCIceTransport.json Outdated Show resolved Hide resolved
@@ -741,56 +691,6 @@
}
}
},
"selectedcandidatepairchange_event": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"onselectedcandidatepairchange": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIceTransport/onselectedcandidatepairchange",
"spec_url": "https://w3c.github.io/webrtc-pc/#dom-rtcicetransport-onselectedcandidatepairchange",
"support": {
"chrome": {
"version_added": "75"
},
"chrome_android": {
"version_added": "75"
},
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "62"
},
"opera_android": {
"version_added": "54"
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": "11.0"
},
"webview_android": {
"version_added": "75"
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder there should be a way to do the sync automatically, or at least a linter for this 🤔

api/RTCIceTransport.json Outdated Show resolved Hide resolved
@@ -145,55 +145,6 @@
"deprecated": false
}
}
},
"reportsSent": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTCRemoteOutboundRtpStreamStats is a dictionary and tricky to test, but I can't find any trace of this in Chromium, Gecko, or WebKit source outside of tests, so I think it should indeed be removed.

},
"reportsSent": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCRemoteOutboundRtpStreamStats/reportsSent",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page exists and will need deleting, presumably.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent mdn/content#5787.

@mdn mdn deleted a comment from jonjarry May 23, 2021
@mdn mdn deleted a comment from jonjarry May 23, 2021
@@ -250,13 +250,13 @@
"description": "<code>gatheringstatechange</code> event",
"support": {
"chrome": {
"version_added": false
"version_added": "75"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this, it was implemented in https://source.chromium.org/chromium/chromium/src/+/d78d9f90c87a37772bbc55a72fb085d2c86faa85 before the whole feature was enabled, and thus shipped with the rest of RTCIceTransport.

},
"reportsSent": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCRemoteOutboundRtpStreamStats/reportsSent",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent mdn/content#5787.

@foolip foolip merged commit dc50911 into mdn:main Jun 8, 2021
@saschanaz saschanaz deleted the remove-nosupport-webrtc branch June 8, 2021 12:43
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 9, 2021
ddbeck added a commit that referenced this pull request Jun 10, 2021
* Bump version to v3.3.7

* Add release note for #10745

* Add release note for #10686

* Add release note for #10744

* Add release note for #10820

* Add release note for #10582

* Add release note for #9464

* Add release note for #10724

* Add release note for #10827

* Add release note for #10829

* Add release note for #10782

* Add stats

* Add release date

* Update stats one last time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants