Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete test #17743

Merged
merged 16 commits into from
Feb 26, 2023
Merged

Fix obsolete test #17743

merged 16 commits into from
Feb 26, 2023

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 9, 2022

This PR fixes the implementedAndRemoved test of the obsolete feature linter to accommodate mirrored statements and handle when other browsers have version_added: false.

Closes #6809 as irrelevant, since this performs the same logic. Naturally fixes #6431.

@github-actions github-actions bot added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Sep 9, 2022
@queengooborg
Copy link
Contributor Author

Note: the tests are failing because there are a lot of features that can be considered obsolete (or are not supported).

@queengooborg queengooborg changed the title Fix obselete test Fix obsolete test Sep 25, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg merged commit 6214c95 into mdn:main Feb 26, 2023
@queengooborg queengooborg deleted the test/obsolete branch February 26, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter: prevent an all "no" row
1 participant