fix(csi/expansion): disable feature-gate RecoverVolumeExpansionFailure

[c3y1huang]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#10411

What this PR does / why we need it:

longhorn/longhorn#10411 (comment)

Special notes for your reviewer:

None

Additional documentation or context

None

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request adds a new command-line argument to the ResizerDeployment component within the NewResizerDeployment function in csi/deployment.go. Specifically, the argument --feature-gates=RecoverVolumeExpansionFailure=false is appended to the deployment’s parameter list alongside the existing --handle-volume-inuse-error=false. Comments in the code reference a related Longhorn GitHub issue. There are no changes to control flow or public entity declarations.

Changes

File	Change Summary
csi/deployment.go	Added the argument --feature-gates=RecoverVolumeExpansionFailure=false in the NewResizerDeployment function; existing --handle-volume-inuse-error=false remains unchanged, with accompanying comments referencing a Longhorn GitHub issue.

Suggested Reviewers

• derekbit
• ChanYiLin

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be22faf and 8815427.

📒 Files selected for processing (1)

• csi/deployment.go (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[c3y1huang]

Test result: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/8142/

[derekbit]

@c3y1huang Thanks for the quick fix. Could you create an IMPROVEMENT ticket for supporting the feature and put it into the backlog? We can handle it later.

[derekbit]

LGTM

[derekbit]

@mergify backport v1.8.x v1.7.x

[mergify]

backport v1.8.x v1.7.x

✅ Backports have been created

• #3560 fix(csi/expansion): disable feature-gate RecoverVolumeExpansionFailure (backport #3559) has been created for branch v1.8.x
• #3561 fix(csi/expansion): disable feature-gate RecoverVolumeExpansionFailure (backport #3559) has been created for branch v1.7.x

[c3y1huang]

@c3y1huang Thanks for the quick fix. Could you create an IMPROVEMENT ticket for supporting the feature and put it into the backlog? We can handle it later.

longhorn/longhorn#10415