fix(metrics): don't parse backup.status.size with an empty string

Longhorn 10358 Signed-off-by: Derek Su <derek.su@suse.com>
longhorn · Feb 11, 2025 · be22faf · be22faf
1 parent 88f3f8e
commit be22faf
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/metrics_collector/backup_collector.go b/metrics_collector/backup_collector.go
@@ -72,8 +72,10 @@ func (bc *BackupCollector) Collect(ch chan<- prometheus.Metric) {
 	for _, backup := range backupLists {
 		if backup.Status.OwnerID == bc.currentNodeID {
 			var size float64
-			if size, err = strconv.ParseFloat(backup.Status.Size, 64); err != nil {
-				bc.logger.WithError(err).Warn("Error get size")
+			if backup.Status.Size != "" {
+				if size, err = strconv.ParseFloat(backup.Status.Size, 64); err != nil {
+					bc.logger.WithError(err).Warn("Error get size")
+				}
 			}
 			backupVolumeName, ok := backup.Labels[types.LonghornLabelBackupVolume]
 			if !ok {