Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csi/expansion): disable feature-gate RecoverVolumeExpansionFailure #3559

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix(csi/expansion): disable feature-gate RecoverVolumeExpansionFailure #3559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions csi/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ func NewResizerDeployment(namespace, serviceAccount, resizerImage, rootDir strin
// Issue: https://github.com/longhorn/longhorn/issues/3303
// TODO: Remove this after upgrading the CSI resizer version that contains the fix of https://github.com/kubernetes-csi/external-resizer/issues/175
"--handle-volume-inuse-error=false",
// Since v1.13.1, the CSI resizer enabled features.RecoverVolumeExpansionFailure
// by default. This silently requeues the PVC without logging the error.
// https://github.com/longhorn/longhorn/issues/10411#issuecomment-2655252262
// TODO: Investigate and fix potential cause of the failure if we want
// to use this feature.
"--feature-gates=RecoverVolumeExpansionFailure=false",
},
int32(replicaCount),
tolerations,
Expand Down
Loading