Feature/async decompression #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenr
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
@lukeplausin
Thank you for the contribution! Looks okay to me. Sorry I took so long to get to this PR.
Just want to give a heads up: this library has Public Domain license (CC0), see LICENSE file.
Are you okay with your contributions being released with this license?
|
Thanks @leenr Yes I am happy with the license |
|
1.1.0 has been released with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @leenr,
I found your project and thought it could help with a problem I had of parsing large compressed files on the fly. When I looked closer I was disappointed that it didn't support decompression, only compression. Later I saw that @Alviner had submitted a merge request some time ago but it hasn't been accepted because of some issues with the code.
I think this is a really useful module and I'd like to help add decompression functionality if I can. I've tried to address some of the issues which you brought up with his original merge request. Please let me know if there's anything else I can do to help get this merged.
Thanks
Resolves #2