Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# add filename support for GZIPCompressedStream #4

Merged
merged 5 commits into from
Dec 8, 2021
Merged

# add filename support for GZIPCompressedStream #4

merged 5 commits into from
Dec 8, 2021

Conversation

0x446
Copy link
Contributor

@0x446 0x446 commented Dec 2, 2021

ADDED:

  • new parameter "file_name" which enables naming of the compressed stream

MODIFIED:

  • incorporated "file_name" in the constructor call "gzip.GzipFile"

REMOVED:

  • nothing

0x446 added 3 commits December 2, 2021 12:44
ADDED:
 - new parameter "file_name" which enables naming of the compressed stream
MODIFIED:
 - incorporated "file_name" in the constructor call "gzip.GzipFile"
REMOVED:
 - nothing
@0x446
Copy link
Contributor Author

0x446 commented Dec 2, 2021

@leenr Not sure why it's still failing. Seems to be related to your runner configuration.
I've tested the code on Python 3.9 and it ran through without errors.
I can't get Python 3.5 to run on my system as well (and it's outdated...).
Feel free to do whatever you want, I'm fine with the license.

Best regards

Copy link
Owner

@leenr leenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x446, thank you for the contribution!
Sorry for the delay: very busy month at work :(

Yeah, Python 3.5 tests are failing because one of the test dependencies (aiomisc) dropped Python 3.5 support, not because of your changes. I will fix the issue in the coming days.

gzip_stream.py Outdated Show resolved Hide resolved
@leenr
Copy link
Owner

leenr commented Dec 6, 2021

@0x446, I fixed the issue in the master branch (#5).
Please merge changes into your branch. I don't have permission to do so.

0x446 and others added 2 commits December 8, 2021 13:08
Co-authored-by: Vladimir Solomatin <progexer@yandex.ru>
@0x446
Copy link
Contributor Author

0x446 commented Dec 8, 2021

@leenr Seems to have worked with your changes to the testing dependencies.

@leenr leenr merged commit 45ca64a into leenr:master Dec 8, 2021
@leenr
Copy link
Owner

leenr commented Dec 8, 2021

Published in version 1.2.0, available through the PyPI.
Thank you again for the contribution!
I'll try to find time to add documentation in README, tests for the feature and add the value to __repr__ at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants