[feat] async reader with gzip decompression on the fly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alviner
commented
May 21, 2020
leenr
requested changes
May 28, 2020
| 'fake text - ~4 KB', 'fake text - ~256 KB'] | ||
| ) | ||
| async def test_gzip_aiter_async_reader(expected, tmpdir): | ||
| tmp_file = tmpdir / "temp.txt" |
There was a problem hiding this comment.
Please, use single quotation through all your changes (unless the use is justified), since the rest of the code use single quotation.
PEP8: "Pick a rule and stick to it".
| __all__ = ( | ||
| 'GZIPCompressedStream', | ||
| 'AsyncGZIPDecompressedStream', |
Comment on lines
+10
to
+11
| from gzip_stream import GZIPCompressedStream, AsyncGZIPDecompressedStream, \ | ||
| BaseAsyncIteratorReader, BUFFER_SIZE |
There was a problem hiding this comment.
Suggested change
| from gzip_stream import GZIPCompressedStream, AsyncGZIPDecompressedStream, \ | |
| BaseAsyncIteratorReader, BUFFER_SIZE | |
| from gzip_stream import ( | |
| AsyncGZIPDecompressedStream, BaseAsyncIteratorReader, | |
| BUFFER_SIZE, GZIPCompressedStream | |
| ) |
| @@ -7,6 +7,7 @@ deps = | |||
| faker | |||
| pytest | |||
| pytest-cov | |||
| aiomisc | |||
| BUFFER_SIZE = 2 ** 10 | ||
|
|
||
|
|
||
| class BaseAsyncReader(abc.ABC): |
There was a problem hiding this comment.
|
#3 has been merged. |
|
1.1.0 has been released with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.