Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Allow private-encrypted pusher channels #31559

Merged
merged 6 commits into from
Feb 24, 2020

Conversation

onurkose
Copy link
Contributor

pusher/pusher-php-server allows private-encrypted channels but broadcaster implementation missing the definitions so it couldn't pass the broadcasting/auth guard.

pusher/pusher-php-server allows private-encrypted channels but broadcaster implementation missing the definitions so it couldn't pass the broadcasting/auth guard.
@GrahamCampbell GrahamCampbell changed the title Update UsePusherChannelConventions.php [6.x] Allow private-encrypted pusher channels Feb 22, 2020
@GrahamCampbell
Copy link
Member

Thanks for this PR, but the implementation doesn't look quite right.

@GrahamCampbell
Copy link
Member

I've corrected this. Your implementation incorrectly replaced private-encrypted-private-123 with 123 instead of private-123.

@onurkose
Copy link
Contributor Author

Great, I was trying to find a better way just like yours.

@taylorotwell taylorotwell merged commit 520188c into laravel:6.x Feb 24, 2020
@onurkose
Copy link
Contributor Author

This is my first contribution after many years of using the framework, so thank all you guys for such a great work.

@driesvints
Copy link
Member

@onurkose thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants