Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pusher end-to-end encryption #263

Closed
it-can opened this issue Apr 2, 2020 · 6 comments
Closed

Support pusher end-to-end encryption #263

it-can opened this issue Apr 2, 2020 · 6 comments

Comments

@it-can
Copy link
Contributor

it-can commented Apr 2, 2020

Would be nice to have support for end-to-end encryption

https://github.com/pusher/pusher-http-php#end-to-end-encryption-beta

@driesvints
Copy link
Member

So this is just to get it working client side right? Because you can already add the options server-side in your config.

@it-can
Copy link
Contributor Author

it-can commented Apr 2, 2020

yeah this seems to be possible within laravel,

laravel/framework#31559

But I think we also need an option to subsribe to private-encrypted- channels... this is not possible in echo as far as I know now...

@driesvints
Copy link
Member

I'll mark this as an enhancement for now. Feel free to pr.

@it-can
Copy link
Contributor Author

it-can commented Apr 2, 2020

ok will try to find some time to create a PR...

it-can added a commit to it-can/echo that referenced this issue Apr 2, 2020
@it-can
Copy link
Contributor Author

it-can commented Apr 2, 2020

@driesvints ok added a PR, can you take a look if I did it correct?

taylorotwell added a commit that referenced this issue Apr 3, 2020
add pusher private-encrypted #263
@derekmd
Copy link
Contributor

derekmd commented May 19, 2020

@driesvints: I believe this issue can be closed? "laravel/echo" 1.7.0 and "laravel/framework" 6.17.0 changes allow private encrypted channels.

@it-can it-can closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants