-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pusher private-encrypted #263 #264
Conversation
Seems to be good. @taylorotwell note that this is to support laravel/framework#31559 |
@it-can did you actually build this and test it in a local application using |
@taylorotwell yes I just tested this. works perfectly. In Laravel set in the config/broadcasting.php file, a base64 encoded masterkey.
Broadcast to a EncryptedPrivateChannel channel.
Subscribe with Echo to a privateEncrypted channel
This works for me |
One thing I notice is a mismatch between backend and frontend. On backend we say "EncryptedPrivate" but on this we say "privateEncrypted"... I would change it to "encryptedPrivate" here in Echo so it matches. |
yeah I also noticed it... Pusher uses private-encrypted... But I guess changing the naming in Laravel is a breaking change... I'll change my PR |
@taylorotwell ok renamed it |
Released Echo 1.7.0 on NPM. |
Thanks Taylor! |
Ok added support for private-encrypted channels (#263) (only for Pusher). Hope this is correct.. I don't use Ts a lot...