Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] More verbs/nouns fixes in disambiguation.xml #11157

Closed
wants to merge 3 commits into from

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Jan 4, 2025

More verbs/nouns fixes.

Summary by CodeRabbit

  • Improvements
    • Enhanced Portuguese language disambiguation rules in LanguageTool.
    • Refined verb pattern matching to improve grammatical accuracy.
    • Updated rule conditions for more precise identification of verb forms in complex sentences.

Copy link
Contributor

coderabbitai bot commented Jan 4, 2025

Walkthrough

The pull request modifies the disambiguation.xml file for Portuguese language modules in LanguageTool. The changes primarily focus on adjusting the disambiguation rules for verbs, specifically the VERB_PRON_VERB_VNOUN_VERBS_RARE rule. The modifications include refining the postag conditions to include an exception for the VMN0000 postag and generalizing previous postag conditions to enhance the identification of verb forms, thereby improving grammatical disambiguation.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml - Modified VERB_PRON_VERB_VNOUN_VERBS_RARE rule: Added exception for VMN0000 and changed postag to V.+ regex.
- Generalized previous postag conditions for broader verb form recognition.

Possibly related PRs

Suggested reviewers

  • jaumeortola
  • p-goulart
  • susanaboatto

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc5f92d and e6849d5.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)
🔇 Additional comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2)

4151-4160: LGTM! Rule refinements improve disambiguation accuracy.

The changes enhance the VERB_PRON_VERB_VNOUN_VERBS_RARE rule by:

  • Adding specific exceptions for infinitive verbs (VMN0000) and third person plural present indicative (VMIP3P0)
  • Handling the informal contraction "tá"
  • Making the token patterns more precise for verb/noun disambiguation

4176-4179: Well-documented test cases!

The examples effectively demonstrate the rule's behavior with diverse scenarios:

  • "Eles iniciaram a revolta..." - verb + noun with article
  • "Um aluno de Stewart..." - verb + noun in a complex sentence
  • "Outras leis proibiram..." - verb + noun with plural forms
  • "De salientar que..." - verb + noun in a different construction

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto
Copy link
Member Author

The idea is that after I process the 950 000 sentences, if all is fine, I will just press “merge” without waiting 30 minutes for the tests to perform.

@marcoagpinto
Copy link
Member Author

I closed this one and opened a “V2” to avoid too much complexity.

@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20250104_1112 branch January 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant