[pt] More verbs/nouns fixes in disambiguation.xml

[marcoagpinto]

More fixes.

Summary by CodeRabbit

• New Features

  • Enhanced grammatical rules for Portuguese, improving disambiguation of verbs followed by pronouns.
  • Updated handling of punctuation and quotation marks for better accuracy in grammatical analysis.

• Bug Fixes

  • Refined conditions for removing rare verbs from appearing as verbs to prevent misclassification.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the disambiguation.xml file for Portuguese language rules in LanguageTool. Key updates include enhancements to the "verb + pronoun" rulegroup, adjustments to disambiguation actions for specific verbs, and refinements to rules preventing misclassification of rare verbs. Additionally, improvements have been made to the handling of punctuation and quotation marks. These changes aim to enhance the accuracy of grammatical analysis and disambiguation in complex Portuguese sentence structures.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	Modified multiple rulegroups related to verb and pronoun disambiguation, rare verb handling, and punctuation tagging.

Possibly related issues

• [pt] Disambiguator verbs/nouns issues — 2024-10-19 #10954: This issue discusses false positives in verb/noun disambiguation, which aligns with the objectives of the changes made in this PR.

Possibly related PRs

• [pt] disambiguation.xml, improved rule ID:RARE_POS #10901: Modifies rules in disambiguation.xml to enhance grammatical disambiguation, relevant to this PR.
• [pt] Improved disambiguator to deal with RARE_POS (verified with ChatGPT 4o) #10957: Updates disambiguation.xml with new and modified rules for disambiguation, directly related to this PR.
• [pt] Verb/noun improvements (pela/como) in disambiguation.xml #11003: Introduces a new rule in the RARE_POS group within disambiguation.xml, related to the main PR's changes.
• [pt] Explicitly added the verbs/nouns words it affects in last rule disambiguation.xml #11005: Adds and modifies rules in disambiguation.xml, connecting to the changes regarding verb and noun disambiguation.
• [pt] More nouns/verbs improved in disambiguation.xml #11009: Focuses on improving disambiguation rules in disambiguation.xml, particularly for verbs and nouns, directly related to this PR.
• [pt] Added more verbs/nouns fixes in disambiguation.xml #11014: Updates rules in disambiguation.xml, refining handling of verbs and nouns, aligning with the objectives of this PR.
• [pt] Another major disambiguation.xml fix in verbs/nouns #11025: Implements improvements in disambiguation.xml to correct false verb classifications, relevant to this PR.
• [pt] Tons of verbs/nouns fixes in disambiguation.xml #11028: Adds a new rule in disambiguation.xml for verb disambiguation, relating to changes in this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11029: Modifies a rule in disambiguation.xml to expand its scope, connecting to the focus of this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11030: Updates rules in disambiguation.xml, enhancing the disambiguation process for verbs and nouns, directly relevant to this PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11033: Reflects modifications to disambiguation.xml that enhance disambiguation, aligning with this PR's changes.
• [pt] More verbs/nouns fixes in disambiguation.xml #11040: Implements additional fixes related to verbs and nouns in disambiguation.xml, connecting to this PR's objectives.
• [pt] More verbs/nouns fixes in disambiguation.xml #11042: Renames a rule in disambiguation.xml, expanding its scope, relevant to this PR's changes.
• [pt] More verbs/nouns fixes in disambiguation.xml #11052: Modifies a rule in disambiguation.xml to include additional tokens, relating to the focus on disambiguation improvements in this PR.

Suggested reviewers

• jaumeortola
• p-goulart
• susanaboatto

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

Line range hint 3903-3920: LGTM! Consider adding more documentation.

The changes to the verb disambiguation pattern look good. Removing VMIP1S0|VMP00SM from the pattern helps prevent false positives. The examples provided demonstrate the rule's effectiveness.

Consider adding a brief comment explaining why these specific verb tags were removed and what issues they were causing.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0bb5abe and dff041a.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)

🔇 Additional comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

3919-3920: LGTM! Examples effectively demonstrate the rule.

The added examples are well-chosen and effectively demonstrate the rule's behavior in complex sentence structures.