[pt] More verbs/nouns fixes in disambiguation.xml

[marcoagpinto]

Major fixes, I hope it won't break Premium.

Summary by CodeRabbit

• New Features

  • Introduced new rule groups for enhanced grammatical disambiguation in Portuguese, including handling complex conjunctions and rare part-of-speech tags.
  • Added specific rules for adverbs, verbs, and nouns to improve contextual understanding.

• Improvements

  • Refined existing rules to enhance filtering capabilities and accuracy of disambiguation.

[coderabbitai]

Walkthrough

The pull request introduces extensive modifications to the disambiguation.xml file for the Portuguese language module of LanguageTool. Key changes include the addition of multiple new rule groups for conjunctions, rare part-of-speech tags, and specific verb forms, alongside updates to existing rules to enhance grammatical disambiguation. The XML structure remains intact, but the content has been significantly expanded and refined, with some rules commented out, indicating potential deprecation or the need for further review.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	- Added rule groups: CONJ_COMPOSTAS, RARE_POS, ADVERB_VERB_NOUN, NUMBER, PUNCTUATION, IGNORE_ENGLISH_WORDS - Added rules: DA, WORKAROUND_MISSING_ADVERBS_POS, PREPOSITION_SE, VERB_VNOUN_NOUN_VERBS_RARE - Updated existing rules for improved filtering and handling - Some rules commented out for potential deprecation or review

Possibly related issues

• [pt] Disambiguator verbs/nouns issues — 2024-10-19 #10954: The changes in this PR address issues related to the misuse of verbs and nouns, which aligns with the objectives of improving disambiguation rules.

Possibly related PRs

• [pt] disambiguation.xml, improved rule ID:RARE_POS #10901: Improves the RARE_POS rule, directly related to the main PR's focus.
• [pt] Improved disambiguator to deal with RARE_POS (verified with ChatGPT 4o) #10957: Modifications to the RARE_POS rule group, aligning closely with the main PR's changes.
• [pt] Explicitly added the verbs/nouns words it affects in last rule disambiguation.xml #11005: Adds rules related to verbs and nouns, complementing the main PR's modifications.
• [pt] Added more verbs/nouns fixes in disambiguation.xml #11014: Fixes related to verbs and nouns, directly connecting to the main PR's focus.
• [pt] More verbs/nouns fix in disambiguation.xml #11017: Focuses on improving disambiguation rules for verbs and nouns, aligning with the main PR's objectives.
• [pt] Another major disambiguation.xml fix in verbs/nouns #11025: Implements improvements in verb and noun identification, a core aspect of the main PR's changes.
• [pt] More verbs/nouns fixes in disambiguation.xml #11029: Additional fixes related to verbs and nouns, supporting the main PR's enhancements.
• [pt] More verbs/nouns fixes in disambiguation.xml #11030: Modifies rules for verb disambiguation, a key focus of the main PR.
• [pt] More verbs/nouns fixes in disambiguation.xml #11033: Corrections related to verbs and nouns, reinforcing the main PR's objectives.
• [pt] More verbs/nouns fixes in disambiguation.xml #11040: Further fixes related to verbs and nouns, aligning with the main PR's focus.
• [pt] More verbs/nouns fixes in disambiguation.xml #11042: Continues fixing issues related to verbs and nouns, directly related to the main PR's changes.
• [pt] More verbs/nouns fixes in disambiguation.xml #11052: Adds fixes for verbs and nouns, consistent with the main PR's objectives.
• [pt] More verbs/nouns fixes in disambiguation.xml #11053: Enhances handling of verbs and nouns, directly supporting the main PR's focus.
• [pt] More verbs/nouns fixes in disambiguation.xml #11057: Refines rules related to verbs and nouns, aligning with the main PR's enhancements.
• [pt] More verbs/nouns fixes in disambiguation.xml #11062: Introduces a new rule for verb disambiguation, significant to the main PR's changes.

Suggested reviewers

• jaumeortola
• p-goulart
• susanaboatto

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2)

Line range hint 300-350: Address TODO comments for exception handling

Several rules are marked with "TODO: exceptions" comments. These should be addressed to ensure robust disambiguation:

• SABE rule
• USUAL rule
• ESTE rule

Consider documenting why these exceptions are needed and what cases they should handle.

Would you like me to help create a tracking issue for implementing these exceptions?

---

Missing test examples for RARE_POS rules

The RARE_POS rule group lacks example test cases in the XML file, which is concerning given its complex disambiguation patterns. While other rules in the file consistently include test examples using <example> tags, this critical rule group doesn't have any test coverage except for the preceding "tão" rule example.

• Add test examples for each pattern in the RARE_POS rule group to validate:
  • Verb/noun disambiguation with prepositions
  • Complex postag patterns
  • Antipattern cases
  • Word lists in the regexp patterns

🔗 Analysis chain

Line range hint 151-300: Document ChatGPT verification process and add test cases

While the RARE_POS rules effectively handle complex verb/noun disambiguation cases, the implementation would benefit from:

1. Documentation detailing how ChatGPT 4 was used for verification
2. Additional test cases to validate the complex patterns

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for existing test cases in the codebase
rg -A 2 "type=\"(?:un)?touched\".*RARE_POS"

Length of output: 43

---

Script:

#!/bin/bash
# Search for test examples in the XML file
rg -A 5 '<example.*>' "languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml"

Length of output: 13050

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 97bdcc1 and 45d9875.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (2 hunks)

🔇 Additional comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

Line range hint 1-150: Well-structured implementation of compound conjunction rules!

The new CONJ_COMPOSTAS rule group effectively handles Portuguese compound conjunctions like "ou seja", "isto é", etc., by correctly tagging them as coordinating conjunctions (CC). The implementation follows XML best practices and includes comprehensive pattern matching.