Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] More verbs/nouns fixes in disambiguation.xml #11130

Merged
merged 5 commits into from
Dec 20, 2024
Merged

[pt] More verbs/nouns fixes in disambiguation.xml #11130

merged 5 commits into from
Dec 20, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Dec 20, 2024 •
edited by coderabbitai bot
Loading

Another milestone in verbs fixing!

Summary by CodeRabbit

  • New Features

    • Introduced a new disambiguation rule for Portuguese verbs following specific prepositions.

  • Bug Fixes

    • Updated existing disambiguation rule for improved accuracy in identifying verb usage with nouns.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024 •
edited
Loading

Walkthrough

The pull request introduces modifications to the Portuguese disambiguation rules in LanguageTool's disambiguation.xml file. A new rule, PELA_COMO_SOBRE_NADA_ACERCA_ELAR_NEXTVERB_VERBS_RARE, has been added to address verb disambiguation when preceded by specific prepositions. Additionally, the existing rule VERB_VNOUN_NOUN_VERBS_RARE has been updated to refine the conditions for removing verb tags when followed by nouns, enhancing the accuracy of grammatical analysis for Portuguese.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml - Added new rule PELA_COMO_SOBRE_NADA_ACERCA_ELAR_NEXTVERB_VERBS_RARE for verb disambiguation
- Modified existing rule VERB_VNOUN_NOUN_VERBS_RARE to refine verb tag removal conditions

Possibly related issues

Possibly related PRs

Suggested reviewers

  • jaumeortola
  • p-goulart
  • susanaboatto
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbfa18d and fd654f6.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

3923-3944: LGTM! Well-structured rule with good test coverage.

The new rule PELA_COMO_SOBRE_NADA_ACERCA_ELAR_NEXTVERB_VERBS_RARE correctly handles verb disambiguation after specific prepositions and words. The implementation is clean and includes comprehensive test cases.

Consider adding more test cases for:

  • Negative cases where the verb tag should be preserved
  • Edge cases with multiple prepositions
  • Cases with intervening adverbs
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c1dd17 and bbfa18d.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

3945-3945: Empty line for readability.

@marcoagpinto
Copy link
Member Author

This takes around 30 minutes to process to each change I make.

That is why I have been creating pull requests, so that after the dataset is processed I can check in ChatGPT and press the "merge" button.

However, this last change "SPS00" removes too many valid results, so I am trying without it now.

I will probably add it to the pull request after I have the dataset processed and at 5am merge it.

@marcoagpinto marcoagpinto merged commit f9532fb into master Dec 20, 2024
5 checks passed
@marcoagpinto
Copy link
Member Author

2.txt

Portuguese (Portugal): 1948 total matches
Portuguese (Portugal): 949999 total sentences considered

This was referenced Dec 22, 2024
Merged
Merged
Merged
This was referenced Jan 4, 2025
Closed
Merged
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@jaumeortola jaumeortola Awaiting requested review from jaumeortola

Assignees
No one assigned
Labels
Portuguese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcoagpinto