[pt] Added/improve APs rule ID:LINKING_VERB_PREDICATE_AGREEMENT

[marcoagpinto]

Antipatterns.

Summary by CodeRabbit

• New Features
  • Introduced a new rule group for verbal agreement with copulative verbs in the Portuguese language module.
  • Enhanced grammatical rules to cover a broader range of linking verbs and their complements.
  • Added example sentences to illustrate the new rule's application.
  • Expanded antipattern definitions to improve rule complexity and coverage.

[coderabbitai]

Walkthrough

The pull request modifies the XML configuration for language rules in the Portuguese language module of LanguageTool. It introduces a new rule group, LINKING_VERB_PREDICATE_AGREEMENT, which focuses on verbal agreement with copulative verbs. The antipattern section is updated to replace specific tokens with more generalized structures, incorporating multiple token definitions based on part-of-speech tagging. Additionally, example sentences are added to illustrate the rule's application, enhancing the overall complexity and coverage of the grammatical rules.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml	- Added new rule group LINKING_VERB_PREDICATE_AGREEMENT - Updated antipattern with multiple token definitions and examples - Introduced tokens for verbs, adverbial phrases, and adjectives/nouns - Added a second antipattern with additional tokens for verbs and punctuation

Possibly related PRs

• [pt] Added APs to rule ID:CONCORDANCIA_SER_GENERO #10919: Adds antipatterns to rule ID:CONCORDANCIA_SER_GENERO, which also deals with grammatical rules concerning the verb "ser."
• [pt] Added APs to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11034: Introduces antipatterns to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS, enhancing grammatical rules in the Portuguese language module.
• [pt] Added AP to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11075: Adds an antipattern for "álbuns solo," related to number agreement.
• [pt] Improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11076: Improves antipatterns in the GENERAL_NUMBER_AGREEMENT_ERRORS rule, directly related to enhancing grammatical rules.
• [pt] Commented out example in grammar.xml for next disambiguator update #11022: Adds an antipattern for the word "tais," relevant to improving grammatical accuracy in Portuguese.

Suggested reviewers

• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89f9409 and d5cff09.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (3)

7788-7791: Address TODO comment regarding regression tests

The TODO comment indicates missing regression tests and enumeration tests. This is important for ensuring rule reliability.

Would you like me to help create:

1. Regression test cases for this rule
2. Enumeration test cases
3. A list of common exceptions that should be handled?

---

7798-7803: Consider revising example sentences

The current examples contain informal/colloquial language ("cu para o ar"). Consider using more formal or neutral examples that still demonstrate the same grammatical pattern.

Example alternatives:

-<example>Tu estás ali horas de cu para o ar.</example>
-<example>Ele está aqui horas de cu para o ar.</example>
+<example>Tu estás ali horas à espera.</example>
+<example>Ele está aqui horas sem fazer nada.</example>

---

7805-7806: Add examples for the second antipattern

The second antipattern lacks example sentences, which would be helpful for testing and documentation purposes.

Consider adding examples like:

<example>Ele está alto, magro e atlético.</example>
<example>O café está quente, forte e aromático.</example>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 239ff78 and 89f9409.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2 hunks)

🔇 Additional comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

7798-7800: Verify POS pattern coverage

The POS patterns (V.+, RG, AQ..P.+|NC.P.+) seem correct, but let's verify they cover all necessary cases.

Also applies to: 7806-7809

✅ Verification successful

Based on the search results, I can see extensive usage of POS patterns throughout the Portuguese rules, particularly in style.xml and grammar.xml. The patterns V.+, RG, and AQ..P.+|NC.P.+ are consistently used across the codebase in similar contexts. Let me generate a final verification response:

POS patterns are correctly implemented and consistent with codebase

The POS patterns used in the rule follow established conventions found throughout the Portuguese rules:

• V.+ is widely used for verb matching, including variations like V.[CIS], V.P.+, etc.
• RG is the standard pattern for adverbs
• AQ..P.+|NC.P.+ follows the common pattern for adjectives/nouns with plural forms

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for similar POS patterns in other Portuguese rules
# This helps ensure consistency and completeness

# Search for similar verb patterns
echo "=== Checking verb patterns ==="
rg -A 1 'postag=.V\.' languagetool-language-modules/pt/

# Search for similar adverb patterns
echo "=== Checking adverb patterns ==="
rg -A 1 'postag=.RG.' languagetool-language-modules/pt/

# Search for similar adjective/noun patterns
echo "=== Checking adjective/noun patterns ==="
rg -A 1 'postag=.AQ\.|NC\.' languagetool-language-modules/pt/

Length of output: 126767