Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added AP to rule ID:LP_PARONYMS #11225

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Feb 3, 2025

An antipattern to fix false positives.

Summary by CodeRabbit

  • New Features

    • Introduced an advanced language rule enhancement for Portuguese that improves the system's ability to recognize specific syntactic structures.
  • Bug Fixes

    • Corrected a minor grammatical inconsistency in an example to ensure clearer, more accurate language usage.

Copy link
Contributor

coderabbitai bot commented Feb 3, 2025

Walkthrough

This pull request updates the Portuguese grammar rules by adding a new <antipattern> section in the grammar.xml file. The new section features multiple <token> elements with regular expression-based part-of-speech matching and provides three usage examples. Additionally, it corrects a typographical error by replacing "E'" with "É" in an existing example.

Changes

File Change Summary
languagetool-language-modules/.../grammar.xml Added a new <antipattern> section with several <token> elements using regex for part-of-speech matching and three examples, plus a minor correction replacing "E'" with "É".

Possibly related PRs

Suggested reviewers

  • jaumeortola

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a7833b and dde4b2d.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (2)

30190-30198: Ensure Consistency and Intent in the New Antipattern Block
The new antipattern block correctly introduces a token sequence with regular-expression–based part-of-speech matching to address false positives for rule LP_PARONYMS. Please verify if the repeated <token postag='CS|PT.+' postag_regexp='yes'/> is intentional (for example, to capture context on both sides of the verb) and that the provided examples sufficiently cover both typical and edge-case scenarios.


30209-30209: Validate the Added Example for Clarity
The newly added example on line 30209—
<example>É no livro que copia da verdade, e castiga o crime que raras vezes a sociedade censura?</example>
is intended to illustrate a potential false-positive case. Please confirm that its syntactic structure, including the embedded comma, clearly represents the antipattern and is consistent in tone and complexity with other examples in this rule.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto marcoagpinto merged commit f660738 into master Feb 3, 2025
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20250203_2028 branch February 3, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant