[pt] Removed "temp_off" from rule ID:DEMASIADO_INVARIAVEL #10909
Conversation
WalkthroughThis pull request modifies an XML configuration file within the LanguageTool project, specifically updating the rule with the ID Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -1060,7 +1060,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. | |||
| </rulegroup> | |||
|
|
|||
|
|
|||
| <rule id='DEMASIADO_INVARIAVEL' name="Demasiada → demasiado" default='temp_off'> | |||
| <rule id='DEMASIADO_INVARIAVEL' name="Demasiada → demasiado"> | |||
There was a problem hiding this comment.
💡 Codebase verification
Documentation and Changelog Updates Required
The removal of default='temp_off' from the 'DEMASIADO_INVARIAVEL' rule enables it by default. However, there are no corresponding updates in the documentation or changelog files. Please update the LanguageTool documentation and release notes to reflect this change and inform users accordingly.
🔗 Analysis chain
LGTM! Consider documentation updates and user communication.
The removal of default='temp_off' from the 'DEMASIADO_INVARIAVEL' rule is correct and aligns with the PR objectives. This change effectively enables the rule by default, which should improve the detection of incorrect usage of "demasiada" instead of "demasiado" in Portuguese.
Given this change:
- Please ensure that the LanguageTool documentation is updated to reflect that this rule is now active by default.
- Consider adding a note to the release changelog about this newly enabled rule.
- It might be beneficial to communicate this change to users, especially those who might have been relying on this rule being off by default.
To ensure proper documentation of this change, please run the following script:
If these searches don't yield results, consider updating the relevant documentation and changelog files to mention this change.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for mentions of DEMASIADO_INVARIAVEL in documentation and changelog files
# Search for mentions in documentation files
echo "Searching for mentions in documentation:"
rg --type md --type txt "DEMASIADO_INVARIAVEL" docs/
# Search for mentions in changelog or release notes
echo "Searching for mentions in changelog or release notes:"
rg --type md --type txt "DEMASIADO_INVARIAVEL" CHANGES.md CHANGELOG.md RELEASE_NOTES.md
Length of output: 555
Script:
#!/bin/bash
# Description: Comprehensive search for mentions of DEMASIADO_INVARIAVEL across the entire codebase
# Search in all markdown and text files
echo "Searching for mentions in all markdown and text files:"
rg --type md --type txt "DEMASIADO_INVARIAVEL"
# If needed, search in all files regardless of type
echo "Searching for mentions in all files:"
rg "DEMASIADO_INVARIAVEL"
Length of output: 434
Heya, @susanaboatto and @p-goulart ,
This one seems to work perfectly:
https://internal1.languagetool.org/regression-tests/via-http/2024-10-01/pt-BR/result_grammar_DEMASIADO_INVARIAVEL%5B1%5D.html
Summary by CodeRabbit