[fr] QUART_DHEURE removing temp_off

[LucieSteib]

Removing temp_off (looong overdue)

Summary by CodeRabbit

• New Features
  • Updated the French grammar rule for "quart d'heure," enhancing its activation in the grammar checking process.

[coderabbitai]

Walkthrough

The pull request modifies the grammar.xml file in the French language modules of LanguageTool by updating the rule with the ID QUART_DHEURE. The default attribute has been removed from this rule's declaration, which may influence its activation in the grammar checking process.

Changes

File	Change Summary
languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml	Updated rule QUART_DHEURE: removed default attribute from <rule id="QUART_DHEURE" ...>

Possibly related PRs

• [pt-PT] Removed "temp_off" from subrule in ID:INFORMALITIES #10885: Removal of the temp_off attribute from a rule in the Portuguese language module.
• [pt] Removed "temp_off" from rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10887: Similar modification with the removal of the temp_off attribute from the OS_DOIS_AS_DUAS_AMBOS_AMBAS rule.
• [pt] Removed "temp_off" from rule ID:DEMASIADO_INVARIAVEL #10909: Removal of the temp_off attribute from the DEMASIADO_INVARIAVEL rule.
• (FR) Rule creation quart d'heure #10965: Introduction of a new rule for QUART_DHEURE, related to the modified rule in the main PR.

Suggested reviewers

• GillouLT

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7061254 and 6e2f232.

📒 Files selected for processing (1)

• languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml (1 hunks)

🔇 Additional comments (2)

languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml (2)

117280-117280: Consider updating documentation

Since this rule is being enabled by default, please ensure that any relevant documentation (like README files or rule documentation) is updated to reflect this change.

Let's check for documentation that might need updates:

---

117280-117280: Verify rule's readiness for production

The removal of default="temp_off" will activate this rule by default. Since it was previously disabled, we should verify its accuracy and false positive rate.

Let's check for existing tests and related documentation:

✅ Verification successful

Rule is well-defined and ready for production

The QUART_DHEURE rule appears to be properly implemented with:

• Clear pattern matching for "quart-d'heure" (with hyphen)
• Appropriate correction suggestion to "quart d'heure" (without hyphen)
• Multiple test examples including both incorrect and correct usage
• Proper error message explaining the standard usage

The removal of temp_off is justified as the rule is well-structured and includes sufficient test coverage within the XML file itself.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for test cases and documentation related to QUART_DHEURE rule

# Search for test cases
echo "Searching for test cases..."
rg -l "QUART_DHEURE" languagetool-language-modules/fr/src/test/

# Check for recent changes or discussions
echo "Checking recent changes..."
rg -l "quart.?d.?heure" languagetool-language-modules/fr/

Length of output: 341

---

Script:

#!/bin/bash
# Let's examine the actual rule implementation and surrounding context
echo "Checking the QUART_DHEURE rule implementation:"
rg -B 2 -A 2 "QUART_DHEURE" languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml

# Let's also check if there are any commented test cases in the XML
echo -e "\nChecking for example/test cases in the rule:"
rg -B 1 -A 1 "<example.*QUART_DHEURE" languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml

Length of output: 660

---

Script:

#!/bin/bash
# Let's get more context around the rule implementation to see the complete rule definition
echo "Getting complete QUART_DHEURE rule definition:"
rg -B 2 -A 15 "QUART_DHEURE" languagetool-language-modules/fr/src/main/resources/org/languagetool/rules/fr/grammar.xml

# Let's also check if there are any unit tests in Java files
echo -e "\nChecking for Java test files:"
fd -e java . languagetool-language-modules/fr/src/test/ --exec rg -l "QUART_DHEURE|quart.?d.?heure" {}

Length of output: 1347

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.