Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Removed "temp_off" from rule ID:DEMASIADO_INVARIAVEL #10909

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[pt] Removed "temp_off" from rule ID:DEMASIADO_INVARIAVEL #10909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,7 +1060,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
</rulegroup>


<rule id='DEMASIADO_INVARIAVEL' name="Demasiada → demasiado" default='temp_off'>
<rule id='DEMASIADO_INVARIAVEL' name="Demasiada → demasiado">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Documentation and Changelog Updates Required

The removal of default='temp_off' from the 'DEMASIADO_INVARIAVEL' rule enables it by default. However, there are no corresponding updates in the documentation or changelog files. Please update the LanguageTool documentation and release notes to reflect this change and inform users accordingly.

🔗 Analysis chain

LGTM! Consider documentation updates and user communication.

The removal of default='temp_off' from the 'DEMASIADO_INVARIAVEL' rule is correct and aligns with the PR objectives. This change effectively enables the rule by default, which should improve the detection of incorrect usage of "demasiada" instead of "demasiado" in Portuguese.

Given this change:

  1. Please ensure that the LanguageTool documentation is updated to reflect that this rule is now active by default.
  2. Consider adding a note to the release changelog about this newly enabled rule.
  3. It might be beneficial to communicate this change to users, especially those who might have been relying on this rule being off by default.

To ensure proper documentation of this change, please run the following script:

If these searches don't yield results, consider updating the relevant documentation and changelog files to mention this change.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for mentions of DEMASIADO_INVARIAVEL in documentation and changelog files

# Search for mentions in documentation files
echo "Searching for mentions in documentation:"
rg --type md --type txt "DEMASIADO_INVARIAVEL" docs/

# Search for mentions in changelog or release notes
echo "Searching for mentions in changelog or release notes:"
rg --type md --type txt "DEMASIADO_INVARIAVEL" CHANGES.md CHANGELOG.md RELEASE_NOTES.md

Length of output: 555

Script:

#!/bin/bash
# Description: Comprehensive search for mentions of DEMASIADO_INVARIAVEL across the entire codebase

# Search in all markdown and text files
echo "Searching for mentions in all markdown and text files:"
rg --type md --type txt "DEMASIADO_INVARIAVEL"

# If needed, search in all files regardless of type
echo "Searching for mentions in all files:"
rg "DEMASIADO_INVARIAVEL"

Length of output: 434

<!-- Used ChatGPT 4o for enhancements and extra accuracy -->
<pattern>
<token regexp='yes' inflected='yes'>andar|continuar|estar|ficar|manter|parecer|revelar|ser|soar|tornar</token>
Expand Down