k8s-ci-robot automatically approve PRs

[IronPan]

What happened:
The https://github.com/k8s-ci-robot starting to automatically approve PRs as soon as they are created

What you expected to happen:
Not approve untill add /approve comment

How to reproduce it (as minimally and precisely as possible):
Create a PR in https://github.com/kubeflow/pipelines

Please provide links to example occurrences, if any:
kubeflow/pipelines#672
kubeflow/pipelines#671
kubeflow/pipelines#670

Anything else we need to know?:

[krzyzacy]

is there a recent change? @fejta @cjwagner

https://github.com/kubeflow/pipelines/blob/master/frontend/OWNERS#L2 @rileyjbauer is an owner for all the file in the PR so the PR will be approved by default, you can turn off implicit self approval if you don't want that?

[IronPan]

Is this a recent change that owner's change will granted with /approve by default? I don't think that's what was happening before.

[IronPan]

could you forward me instruction how to turn implicit self approval off? thanks!

[jlewi]

I think this might be an improvement.

IIUC it used to be the case that if someone in the OWNERs file sends out a PR for approval; if that PR is LGTM'd by someone not in the approvers file. Then the PR author would have to do "/approve".

So with the new behavior it seems like if PR author is also an approver they might nolonger need to explicitly add "/approve"; the LGTM is sufficient

If a PR author doesn't want a PR to be merged automatically; then they could mark it WIP or explicitly place a hold.

[cjwagner]

Yes, the default behavior was recently changed: #10435 @fejta

[IronPan]

thanks agree this is a improvement. i was worrying about PR approved without owner approving it.
Close this issue

[IronPan]

/close

[k8s-ci-robot]

@IronPan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ark-kun]

Now it's automatically LGTMing PRs: kubeflow/pipelines#662 (comment)

/reopen

[k8s-ci-robot]

@Ark-kun: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

Now it's automatically LGTMing PRs: kubeflow/pipelines#662 (comment)

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ark-kun]

Sorry, I got confused because GitHub only updated the main discussion thread, but not the comment thread, so there wasn't any LGTM comment when I searched.
The robot started auto-approving PRs today so I thought it was the case here.

/close