-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cinder-csi-plugin] update topology feature docs #1296
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ramineni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Hmm...I found github automatically add |
@lingxiankong seems it's added recently, we should remove such auto label IMHO |
Thank you @ramineni |
+1 , @lingxiankong any idea we could do that? |
No idea, found this kubernetes/test-infra#10721 but it was last year. |
What this PR does / why we need it:
https://github.com/kubernetes-csi/external-provisioner/blob/v1.6.0/pkg/features/features.go#L38 , Topology feature doesnt seem to be enabled by default. So updating the docs.
xref: #1293
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: