Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] update topology feature docs #1296

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

ramineni
Copy link
Contributor

What this PR does / why we need it:
https://github.com/kubernetes-csi/external-provisioner/blob/v1.6.0/pkg/features/features.go#L38 , Topology feature doesnt seem to be enabled by default. So updating the docs.

xref: #1293
Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2020
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3129305 into kubernetes:master Oct 29, 2020
@lingxiankong
Copy link
Contributor

Hmm...I found github automatically add approved label in the PRs submitted by the person who has approved permission.

@jichenjc
Copy link
Contributor

@lingxiankong seems it's added recently, we should remove such auto label IMHO

@zetaab
Copy link
Member

zetaab commented Oct 30, 2020

Thank you @ramineni

@ramineni
Copy link
Contributor Author

@lingxiankong seems it's added recently, we should remove such auto label IMHO

+1 , @lingxiankong any idea we could do that?

@lingxiankong
Copy link
Contributor

+1 , @lingxiankong any idea we could do that?

No idea, found this kubernetes/test-infra#10721 but it was last year.

powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants