Add build version to side nav #670
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3cc26d9 to
0923d9e
Compare
| expect(isCollapsed(tree)).toBe(false); | ||
|
|
||
| (window as any).innerWidth = narrowWidth; | ||
| const resizeEvent = new Event('resize'); | ||
| window.dispatchEvent(resizeEvent); | ||
| expect(isCollapsed(tree)).toBe(false); | ||
| }); | ||
|
|
||
| it('populates the display build information using the response from the healthz endpoint', async () => { | ||
| const buildInfo = { |
There was a problem hiding this comment.
Is this doing something different than what's done in the beforeAll block?
There was a problem hiding this comment.
No, but I thought it would be better to show it explicitly here so it's clear where the expectations come from
|
|
||
| expect(tree.state('displayBuildInfo')).toEqual(expect.objectContaining({ | ||
| commitHash: 'unknown', | ||
| commitUrl: 'https://www.github.com/kubeflow/pipelines', |
There was a problem hiding this comment.
nit: This part is being tested below too, did you mean to keep both tests? Maybe remove this line from here if so?
There was a problem hiding this comment.
Whoops. Yep, removed
|
/test kubeflow-pipeline-build-image |
|
related #590 |
|
/test kubeflow-pipeline-e2e-test |
2106c72 to
17961f0
Compare
|
/lgtm |
…low#670) * For now, it looks like using multiple acm-repo (i.e. different repos for different clusters) will work better than trying to use a single acm-repo and cluster selectors. * I was hitting problems with the fact that Tekton can't be installed via ACM right now (it violates certain validation constraints). * I only wanted to install tekton on the auto-deploy cluster (kf-ci-v1) and not the kf-ci-management cluster but I was stil getting errors from ACM complaining the Tekton configs were invalid. * So as a work around I renamed acm-repo -> acm-repos with the intent we will have multiple subdirectories corresponding to different repos * A given cluster can then choose which cluster to enroll in * Create a new cluster for the KF chatbot (see kubeflow/code-intelligence#142) * The cluster will be managed using CNRM and ACM on the kf-ci-management cluster. So we need to check in the configs. * The source (kustomize packages for the manifests) is in kubeflow/code-intelligence#145
If the information is reachable, the side nav will now display the first 7 characters of the commit hash that the API server image was built from, and link to that commit.
Note to reviewers: hide whitespace changes
This change is