Cleanup and PR comments

kubeflow · Jan 14, 2019 · 2106c72 · 2106c72
1 parent 0923d9e
commit 2106c72
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/frontend/mock-backend/mock-api-middleware.ts b/frontend/mock-backend/mock-api-middleware.ts
@@ -77,8 +77,7 @@ export default (app: express.Application) => {
 
   app.get('/hub/', (_, res) => {
     res.sendStatus(200);
-    // res.send({ ok: true });
-  });
+  }); 
 
   function getSortKeyAndOrder(defaultSortKey: string, queryParam?: string): { desc: boolean, key: string } {
     let key = defaultSortKey;

diff --git a/frontend/src/components/SideNav.test.tsx b/frontend/src/components/SideNav.test.tsx
@@ -290,7 +290,6 @@ describe('SideNav', () => {
 
     expect(tree.state('displayBuildInfo')).toEqual(expect.objectContaining({
       commitHash: 'unknown',
-      commitUrl: 'https://www.github.com/kubeflow/pipelines',
     }));
   });
 

diff --git a/frontend/src/components/SideNav.tsx b/frontend/src/components/SideNav.tsx
@@ -126,6 +126,14 @@ export const css = stylesheet({
     justifyContent: 'center',
     marginLeft: 12,
   },
+  marginBottom8: {
+    marginBottom: 8,
+  },
+  openInNewTabIcon: {
+    height: 12,
+    marginLeft: 5,
+    width: 12,
+  },
   root: {
     background: sideNavColors.bg,
     paddingTop: 12,
@@ -263,7 +271,7 @@ export default class SideNav extends React.Component<SideNavProps, SideNavState>
                   classes(css.button, collapsed && css.collapsedButton)}>
                   <JupyterhubIcon style={{ height: 20, width: 20 }} />
                   <span className={classes(collapsed && css.collapsedLabel, css.label)}>Notebooks</span>
-                  <OpenInNewIcon style={{ height: 12, width: 12, marginLeft: 5, marginBottom: 8 }} />
+                  <OpenInNewIcon className={classes(css.openInNewTabIcon, css.marginBottom8)} />
                 </Button>
               </a>
             </Tooltip>
@@ -281,7 +289,7 @@ export default class SideNav extends React.Component<SideNavProps, SideNavState>
               <a href={displayBuildInfo.commitUrl} className={classes(css.buildHash, commonCss.unstyled)}
                 target='_blank'>
                 {displayBuildInfo.commitHash}
-                <OpenInNewIcon style={{ height: 12, width: 12, marginLeft: 5 }} />
+                <OpenInNewIcon className={classes(css.openInNewTabIcon)} />
               </a>
             </div>
           </Tooltip>
-Original file line number
+Diff line change
@@ Expand Up / @@ -290,7 +290,6 @@ describe('SideNav', () => { @@
         expect(tree.state('displayBuildInfo')).toEqual(expect.objectContaining({
           commitHash: 'unknown',
-          commitUrl: 'https://www.github.com/kubeflow/pipelines',
         }));
       });
@@ Expand Down @@