OWNERS: add ArangoGutierrez as an approver #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ArangoGutierrez in addition to this PR you need to be member of the kubernetes-sigs org Apply for membership by filing an issue in kubernetes/org. Before filing an issue, read this 😄 |
|
/retest |
|
/verify-owners |
|
/lgtm |
courtneypacheco
added a commit
to courtneypacheco/node-feature-discovery-operator
that referenced
this pull request
Sep 7, 2021
# This is the 1st commit message: Adding documentation to 'main.go' to describe functions, vars, etc. Adding documentation to the code in 'main.go' so that contributors and developers can understand the purpose of each function, variable, etc.. # This is the commit message kubernetes-sigs#2: Adding documentation to funcs and vars in nodefeaturediscovery_controller.go Adding documentation to various functions and variables within the nodefeaturediscovery_controller.go file so that users and contributors can have a deeper understanding of how the reconciliation process works with the NFD Operator. # This is the commit message kubernetes-sigs#3: Rebase to master # This is the commit message kubernetes-sigs#4: Adding documentation to the NFD controller resources file Adding documentation describing the funcs, vars, etc. in the NFD controller resources file so that users and contributors can understand how they all work. # This is the commit message kubernetes-sigs#5: Adding docs to NFD state funcs related to NFD itself (not just the operator) Adding documentation to the NFD state functions related to NFD itself so that users and contributors can understand how NFD works with the NFD operator, especially if they are looking at another file that references these functions and the NFD struct. # This is the commit message kubernetes-sigs#6: Merge master Signed-off-by: Courtney Pacheco <cpacheco@redhat.com> # This is the commit message kubernetes-sigs#7: Rebase to master Signed-off-by: Courtney Pacheco <cpacheco@redhat.com> # This is the commit message kubernetes-sigs#8: Rebase to master - fix incorrect previous rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.