Dockerfile: fetch build dependencies in a separate layer #6
Conversation
Effectively caches them, making subsequent builds much faster (assuming go.mod and go.sum) are not changed).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
ping @ArangoGutierrez @zvonkok /remove-lifecycle stale |
|
@ArangoGutierrez: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Good catch @marquiz , caching the go layers will save us some mins on every build |
|
LooooL i am no in the OWNERS file... can't help here |
|
/lgtm |
I submitted #8 to fix that issue 😄 |
# This is the 1st commit message: Adding documentation to 'main.go' to describe functions, vars, etc. Adding documentation to the code in 'main.go' so that contributors and developers can understand the purpose of each function, variable, etc.. # This is the commit message kubernetes-sigs#2: Adding documentation to funcs and vars in nodefeaturediscovery_controller.go Adding documentation to various functions and variables within the nodefeaturediscovery_controller.go file so that users and contributors can have a deeper understanding of how the reconciliation process works with the NFD Operator. # This is the commit message kubernetes-sigs#3: Rebase to master # This is the commit message kubernetes-sigs#4: Adding documentation to the NFD controller resources file Adding documentation describing the funcs, vars, etc. in the NFD controller resources file so that users and contributors can understand how they all work. # This is the commit message kubernetes-sigs#5: Adding docs to NFD state funcs related to NFD itself (not just the operator) Adding documentation to the NFD state functions related to NFD itself so that users and contributors can understand how NFD works with the NFD operator, especially if they are looking at another file that references these functions and the NFD struct. # This is the commit message kubernetes-sigs#6: Merge master Signed-off-by: Courtney Pacheco <cpacheco@redhat.com> # This is the commit message kubernetes-sigs#7: Rebase to master Signed-off-by: Courtney Pacheco <cpacheco@redhat.com> # This is the commit message kubernetes-sigs#8: Rebase to master - fix incorrect previous rebase
Effectively caches them, making subsequent builds much faster (assuming
go.mod and go.sum) are not changed).