Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run nfd-master as Deployment #4

Closed
marquiz opened this issue Apr 20, 2020 · 19 comments · Fixed by #141
Closed

Run nfd-master as Deployment #4

marquiz opened this issue Apr 20, 2020 · 19 comments · Fixed by #141
Assignees
@ArangoGutierrez
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@marquiz
Copy link
Contributor

marquiz commented Apr 20, 2020

Run nfd-master as Deployment instead of a DaemonSet, similar what the NFD upstream deployment template does.

Makes it possible to deploy NFD in managed clusters which have no master nodes.
@marquiz marquiz mentioned this issue Apr 20, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2020
@marquiz
Copy link
Contributor Author

marquiz commented Aug 19, 2020

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 19, 2020
@ArangoGutierrez
Copy link
Contributor

My concern with this concept is that worker nodes could tag them selves as Masters and gain privileges on the system. How could we avoid that on a Vanilla Kubernetes deployment?

@marquiz
Copy link
Contributor Author

marquiz commented Sep 7, 2020

How would a Deployment be different in terms of privileges??

@ArangoGutierrez
Copy link
Contributor

From the issue init comment "clusters which have no master nodes." , then a Deployment will create masters and a way to create labels without controlling the head of the cluster. I may be wrong tho, not a security expert by no means, I keep my password on a post-it. but I think is something worth double checking before going into that direction

@marquiz
Copy link
Contributor Author

marquiz commented Sep 7, 2020

Master nodes and nfd-master are a different/separate thing. When you run nfd-master it doesn't label the node it's running on as a master node. You need to run nfd-master somewhere in the cluster (in order for NFD to be able to work i.e. create node labels). If there are no master nodes in the cluster you'll end up with a non-working state when using a DaemonSet.

Nevertheless, the thinking behind running nfd-master on master node(s) by default was still security. Nfd-master would be "safer" there because master nodes are unlinkely to run any user workloads. In any case, I think the operator should take the "masterless" cluster into consideration, only use Deployment in that case or smth.

@ArangoGutierrez ArangoGutierrez mentioned this issue Sep 23, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2020
@marquiz
Copy link
Contributor Author

marquiz commented Dec 7, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2021
@marquiz
Copy link
Contributor Author

marquiz commented Mar 10, 2021

Still valid
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2021
@ArangoGutierrez
Copy link
Contributor

@zvonkok I would like to get your eyes on this issue

@ArangoGutierrez
Copy link
Contributor

/assign

@ArangoGutierrez
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 11, 2021
courtneypacheco added a commit to courtneypacheco/node-feature-discovery-operator that referenced this issue Sep 7, 2021
@courtneypacheco
# This is a combination of 8 commits.
95faba4 
# This is the 1st commit message:

Adding documentation to 'main.go' to describe functions, vars, etc.

Adding documentation to the code in 'main.go' so that contributors
and developers can understand the purpose of each function, variable,
etc..

# This is the commit message kubernetes-sigs#2:

Adding documentation to funcs and vars in nodefeaturediscovery_controller.go

Adding documentation to various functions and variables within the
nodefeaturediscovery_controller.go file so that users and contributors
can have a deeper understanding of how the reconciliation process
works with the NFD Operator.

# This is the commit message kubernetes-sigs#3:

Rebase to master

# This is the commit message kubernetes-sigs#4:

Adding documentation to the NFD controller resources file

Adding documentation describing the funcs, vars, etc. in the NFD
controller resources file so that users and contributors can
understand how they all work.

# This is the commit message kubernetes-sigs#5:

Adding docs to NFD state funcs related to NFD itself (not just the operator)

Adding documentation to the NFD state functions related to NFD itself
so that users and contributors can understand how NFD works with the NFD
operator, especially if they are looking at another file that references
these functions and the NFD struct.

# This is the commit message kubernetes-sigs#6:

Merge master

Signed-off-by: Courtney Pacheco <cpacheco@redhat.com>

# This is the commit message kubernetes-sigs#7:

Rebase to master

Signed-off-by: Courtney Pacheco <cpacheco@redhat.com>

# This is the commit message kubernetes-sigs#8:

Rebase to master - fix incorrect previous rebase
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor

/open

@ArangoGutierrez ArangoGutierrez mentioned this issue Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArangoGutierrez ArangoGutierrez

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run nfd-master as Deployment ArangoGutierrez/node-feature-discovery-operator
5 participants
@marquiz @ArangoGutierrez @k8s-ci-robot @fejta-bot @k8s-triage-robot