Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestRemoteLoad_LocalProtocol #4844

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Oct 31, 2022

Testing out if this fixes the failure on master

Using the workaround described in https://bugs.launchpad.net/ubuntu/+source/git/+bug/1993586

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@natasha41575
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2022
@natasha41575 natasha41575 changed the title remote load test fix fix TestRemoteLoad_LocalProtocol Oct 31, 2022
@natasha41575 natasha41575 marked this pull request as ready for review October 31, 2022 15:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yuwenma October 31, 2022 15:49
@natasha41575
Copy link
Contributor Author

natasha41575 commented Oct 31, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 31, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 31, 2022
@natasha41575
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022
@koba1t
Copy link
Member

koba1t commented Oct 31, 2022

I think this workaround solves the test failure on the master.
And, I checked to fail tests for add git config --global protocol.file.allow user.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 997e6fc into kubernetes-sigs:master Oct 31, 2022
@koba1t
Copy link
Member

koba1t commented Oct 31, 2022

Oh... Was that bad to type to /lgtm?
If you wanted to do other checks before merging the master, That apologizes from me.

@natasha41575
Copy link
Contributor Author

If you wanted to do other checks before merging the master, That apologizes from me.

That's okay! Thanks for the LGTM. This will at least unblock other PRs for now. I already let the other maintainers know about this PR, so they can take a look if they'd like.

@natasha41575 natasha41575 deleted the local_protocol_test branch October 31, 2022 18:19
elisshafer pushed a commit to elisshafer/kustomize that referenced this pull request Dec 8, 2022
* remote load test fix

* fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants