Update golangci-lint version (1.49.0 -> 1.50.1) and enable linters: dupword and testableexamples

[oscr]

• Update golangci-lint version from 1.49.0 -> 1.50.1
• In golangci-lint 1.50.0 logrlint was renamed loggercheck. Referencehttps://github.com/golangci/golangci-lint/releases/tag/v1.50.0
• Enable new linters: dupword and testableexamples introduced in 1.50.0

[oscr]

Looks like problems with tests or master. Failing on master since: https://github.com/kubernetes-sigs/kustomize/actions/runs/3300605518

[koba1t]

Hi @oscr

Thanks for you contributions.

Update golangci-lint version from 1.49.0 -> 1.50.0

Look like you are using v1.50.1. Are you typo for version in that message?

Could you enable testableexamples linter that added by golang-ci v1.50.0 ?

[koba1t]

/assign koba1t

[oscr]

@koba1t Thank you for the review and you are right. I mixed up the version in the pr description. I fixed it and enabled the additional linter as requested.

[oscr]

/retest

[koba1t]

I think these code changes are not the cause of test failures and tests are successful on my pc.

Could you try to re-run GitHub actions?

[oscr]

Agree. The tests seem to be broken on master: https://github.com/kubernetes-sigs/kustomize/actions/runs/3331584091

[oscr]

But I retriggered GH actions so lets see.

[koba1t]

Looks like @natasha41575 working on this problem at #4844.

[koba1t]

#4844 is merged.

Could you try to rebase master?
I think that fix test failure on CI.

[oscr]

Looks like the fix worked perfectly.

[koba1t]

/lgtm

[KnVerey]

/approve

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment