-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kyaml's dependency swag to v0.22.3 #4830
update kyaml's dependency swag to v0.22.3 #4830
Conversation
Welcome @summer-dev! |
Hi @summer-dev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@summer-dev: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please sign the CLA |
Done,thanks for your remind :) |
Thanks for your review @mengqiy @phanimarupaka |
/ok-to-test |
/approve |
dear natasha41575 : i'm confused about the failure reason of this sute : test-unit-non-plugin, it seems that some missed files are needed during testing. i wonder where i can get these missed files? how can I solve this problem, thanks |
Hi @summer-dev |
i wish another LGTM gift :) |
Thanks, @summer-dev! /assign koba1t |
Hi, after executing
About 90 files are modified, should I commit theses changes to my forked repo? and then waiting to be merged. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, summer-dev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @summer-dev
Thanks! Please commit these files! I'm sorry for the inconvenience. Please exec |
/lgtm Hi @natasha41575 |
kyaml now depends on swag v0.19.14 which itself depends on https://github.com/niemeyer/pretty, this pretty package is a fork
of https://github.com/kr/pretty, the previous pretty is out of date,while the latter is maintained well,
swag v0.22.3 has already updated its dependency to kr's, I think it's necessary to update kyaml's too
thanks.