-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD cannot be generated for Unstructured type #301
Comments
4 tasks
Have you considered using a |
I haven't yet. If we have to change the type of the field, this will require an interface change on our CRDs though, so, it'd be awesome if we can get the |
muvaf
added a commit
to muvaf/crossplane
that referenced
this issue
Aug 9, 2019
Unstructured type as CR field type. See kubernetes-sigs/controller-tools#301 - Leave comment about being able to use only LabelSelector field Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
hasheddan
pushed a commit
to muvaf/crossplane
that referenced
this issue
Aug 9, 2019
Unstructured type as CR field type. See kubernetes-sigs/controller-tools#301 - Leave comment about being able to use only LabelSelector field Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Updating the link referenced above to the |
displague
added a commit
to displague/crossplane
that referenced
this issue
Aug 23, 2019
Controller-tools v0.2.0 removes our need to use the custom fork since kubernetes-sigs/controller-tools#301 has been released in v0.2.0. Additionally, there are some features present in the v0.2.0 release that were not in the beta.5 release, such as `controller-gen crd:maxDescLen=0` which may prove useful to address crossplane#698 Signed-off-by: Marques Johansson <marques@upbound.io>
displague
added a commit
to displague/crossplane
that referenced
this issue
Aug 23, 2019
Controller-tools v0.2.0 removes our need to use the custom fork since kubernetes-sigs/controller-tools#301 has been released in v0.2.0. Additionally, there are some features present in the v0.2.0 release that were not in the beta.5 release, such as `controller-gen crd:maxDescLen=0` which may prove useful to address crossplane#698 Signed-off-by: Marques Johansson <marques@upbound.io>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We got a type that has
*unstructured.Unstructured
as one of its fields and we're generating CRD off of it. I am working on transition to controller-tools v0.2.0 and running into the following error:Looked into the source code and there really isn't a tag for
Object
field, however, even if I manually write the json tag, it returns the following:Is there a way to have controller-tools handle this? I imagine it's more complicated due to having
interface{}
as value but I'd appreciate if we can find a way for it to work. Note that it worked with version 0.1.9You can see the ongoing work here crossplane/crossplane#665
You can see the versions used in
Gopkg.toml
.To reproduce, checkout the PR and run
make manifests
You can also try to have
*unstructured.Unstructured
typed field in any struct and try to generate CRD.The text was updated successfully, but these errors were encountered: