- Use modified fork of controller-tools to be able to use

Unstructured type as CR field type. See kubernetes-sigs/controller-tools#301 - Leave comment about being able to use only LabelSelector field Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
muvaf · Aug 9, 2019 · a0d56a8 · a0d56a8
1 parent 6d79f35
commit a0d56a8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/Gopkg.toml b/Gopkg.toml
@@ -44,9 +44,10 @@ required = [
   name="sigs.k8s.io/controller-runtime"
   version="v0.2.0-beta.5"
 
-[[constraint]]
+[[override]]
   name="sigs.k8s.io/controller-tools"
-  version = "v0.2.0-beta.5"
+  source = "https://github.com/muvaf/controller-tools.git"
+  revision = "301a879da11105676f319f9080278a54b956d07f"
 
 # temp stanzas
 [[override]]

diff --git a/apis/workload/v1alpha1/types.go b/apis/workload/v1alpha1/types.go
@@ -55,6 +55,9 @@ type KubernetesApplicationSpec struct {
 	// KubernetesApplicationResources.
 	ResourceSelector *metav1.LabelSelector `json:"resourceSelector"`
 
+	// TODO(muvaf): Only MatchLabels field of LabelSelector is used. Incorporate
+	// MatchExpressions as well when it's available as controller-runtime ListOption
+
 	// ClusterSelector selects the clusters to which this application may be
 	// scheduled. Leave both match labels and expressions empty to match any
 	// cluster.