Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withItems incorrect type in full CRD #3578

Closed
alexec opened this issue Jul 23, 2020 · 5 comments · Fixed by #3809
Closed

withItems incorrect type in full CRD #3578

alexec opened this issue Jul 23, 2020 · 5 comments · Fixed by #3809
Assignees
@alexec
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Jul 23, 2020

Is

                            withItems:
                              items:
                                properties:
                                  value:
                                    format: byte
                                    type: string
                                required:
                                - value
                                type: object
                              type: array

Should be:

                            withItems:
                              items:
                                type: object
                              type: array
@alexec alexec self-assigned this Aug 17, 2020
@alexec
Copy link
Contributor Author

alexec commented Aug 17, 2020

It is also wrong for parallel steps.

@alexec
Copy link
Contributor Author

alexec commented Aug 17, 2020

kubernetes-sigs/controller-tools#391

@alexec
Copy link
Contributor Author

alexec commented Aug 17, 2020

kubernetes-sigs/controller-tools#301

alexec added a commit to alexec/argo-workflows that referenced this issue Aug 18, 2020
@alexec
fix: Corrects CRD and Swagger types. Fixes argoproj#3578
334c613
This was referenced Aug 18, 2020
Merged
Closed
@alexec alexec linked a pull request Aug 20, 2020 that will close this issue
docs: Amend link to the Workflow CRD. Fixes #3827 #3828
Merged
6 tasks
@alexec alexec reopened this Aug 20, 2020
@alexec
Copy link
Contributor Author

alexec commented Aug 20, 2020

Wrong issue linked.

@alexec alexec removed a link to a pull request Aug 20, 2020
docs: Amend link to the Workflow CRD. Fixes #3827 #3828
Merged
6 tasks
alexec added a commit that referenced this issue Aug 27, 2020
@alexec
fix: Corrects CRD and Swagger types. Fixes #3578 (#3809)
359ee8d
@alexec
Copy link
Contributor Author

alexec commented Sep 2, 2020

Available for testing in v2.10.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Corrects CRD and Swagger types. Fixes #3578 alexec/argo-workflows
1 participant
@alexec