master: update release-tools #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6a88c6 Merge pull request kubernetes-csi#113 from xing-yang/install_snapshot_controller 45ec4c6 Fix the install of snapshot CRDs and controller 5d874cc Merge pull request kubernetes-csi#112 from xing-yang/cleanup 79bbca7 Cleanup d437673 Merge pull request kubernetes-csi#111 from xing-yang/update_snapshot_v1_rc 57718f8 Update snapshot CRD version git-subtree-dir: release-tools git-subtree-split: c6a88c6
Update release tools
This addresses the issue where mixing klog/v1 and klog/v2 leads to incomplete output because a non-default log level was only set in klog/v1.
update klog to v2.4.0
Done with `go get -u ./...` The newer Ginkgo change the semantic of Describe() so that the function callback only gets invoked sometime later, which is why we need to rebind the "test" loop variable.
dependency update
This addresses a regression in [1] causing plugins to return an in-use error (FAILED_PRECONDITION) when a sourcing resource (i.e., a snapshot or a volume) is deleted before the sourced volume is. [1]: kubernetes-csi#261
1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag 9f10459 prow.sh: support building Kubernetes for a specific version fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate ece0f50 check namespace for snapshot-controller dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 1d60e77
master: update release-tools
…ttacher Add external-attacher to mock CSI driver deployment
…-from-returning-in-use-error-for-source-volumes Prevent plugin from returning in-use error for source volumes
7bc70e5 Merge pull request kubernetes-csi#129 from pohly/squash-documentation e0b02e7 README.md: document usage of --squash 316cb95 Merge pull request kubernetes-csi#132 from yiyang5055/bugfix/boilerplate 26e2ab1 fix: default boilerplate path 1add8c1 Merge pull request kubernetes-csi#133 from pohly/kubernetes-1.20-tag 3e811d6 prow.sh: fix "on-master" prow jobs git-subtree-dir: release-tools git-subtree-split: 7bc70e5
By running the mock driver in proxy mode with the csi.sock made available via another *listening* endpoint it becomes possible to run the actual driver code elsewhere, for example embedded inside an e2e.test binary. The second endpoint can be a TCP port that can be reached from outside of a Kubernetes cluster, either via a service or port-forwarding. The same can be done with "socat UNIX-LISTEN:/csi/csi.sock,fork TCP-LISTEN:9000,reuseport", but the implementation inside the mock driver has some advantages compared to that: - the same image as for normal mock driver testing can be used - the mock driver keeps the second listen socket open at all times, so a client connecting to it doesn't get "connection refused" errors, which happens while socat hasn't forked to accept such a connection
master: update release-tools
Caught by verify-typecheck.sh after importing the code into Kubernetes: ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:404:20: math.MaxUint32 (untyped int constant 4294967295) overflows int ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:795:20: math.MaxUint32 (untyped int constant 4294967295) overflows int ERROR(linux/386): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:404:20: math.MaxUint32 (untyped int constant 4294967295) overflows int ERROR(linux/386): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:795:20: math.MaxUint32 (untyped int constant 4294967295) overflows int ERROR(windows/386): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:404:20: math.MaxUint32 (untyped int constant 4294967295) overflows int ERROR(windows/386): /home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service/controller.go:795:20: math.MaxUint32 (untyped int constant 4294967295) overflows int Instead of producing our own error message, we can show the original value and the error from strconv.
Add error checks
mock: act as proxy
master: update release-tools
support node VOLUME_MOUNT_GROUP cap in test
kubernetes-csi/csi-release-tools@5489de6 Merge kubernetes-csi/csi-release-tools#174 from mauriciopoppe/bump-kind-version kubernetes-csi/csi-release-tools@0c675d4 Bump kind version to v0.11.1 kubernetes-csi/csi-release-tools@ef69a88 Merge kubernetes-csi/csi-release-tools#173 from nick5616/add-ws2022 kubernetes-csi/csi-release-tools@44c710c added WS2022 to build platforms kubernetes-csi/csi-release-tools@0883be4 Merge kubernetes-csi/csi-release-tools#171 from pohly/example-commands kubernetes-csi/csi-release-tools@02cda51 build.make: support binaries outside of cmd, with optional go.mod kubernetes-csi/csi-release-tools@65922ea Merge kubernetes-csi/csi-release-tools#170 from pohly/canary-snapshot-controller kubernetes-csi/csi-release-tools@c0bdfb3 prow.sh: deploy canary snapshot-controller in canary jobs kubernetes-csi/csi-release-tools@0438f15 Merge kubernetes-csi/csi-release-tools#167 from c0va23/feature/release-armv7-image kubernetes-csi/csi-release-tools@4786f4d Merge kubernetes-csi/csi-release-tools#168 from msau42/update-release-prereq kubernetes-csi/csi-release-tools@6a2dc64 Remove requirement to be top-level approver. Only maintainers membership is required to do a release kubernetes-csi/csi-release-tools@30a4f7b Release armv7 image kubernetes-csi/csi-release-tools@ac8108f Merge kubernetes-csi/csi-release-tools#165 from consideRatio/pr/update-github-links-ref-to-master-to-HEAD kubernetes-csi/csi-release-tools@999b483 docs: make github links reference HEAD instead of main kubernetes-csi/csi-release-tools@fd67069 docs: make github links reference HEAD instead of master git-subtree-dir: release-tools git-subtree-split: 5489de6
…master master: update release-tools
The driver got replaced by an enhanced csi-driver-host-path. "make test-sanity" will now check out the csi-driver-host-path source, build it and run sanity testing as root. This is needed because in contrast to the mock driver, the csi-driver-host-path actually does bind mounts. Some special ways of testing a CSI driver (with credentials and different endpoints) don't get tested anymore because csi-driver-host-path does not support those modes of operation.
remove obsolete mock driver
changelog for v4.3.0
kubernetes-csi/csi-release-tools@5b9a1e0 Merge kubernetes-csi/csi-release-tools#175 from jimdaga/patch-1 kubernetes-csi/csi-release-tools@5eeb602 images: use k8s-staging-test-infra/gcb-docker-gcloud git-subtree-dir: release-tools git-subtree-split: 5b9a1e0
master: update release-tools
kubernetes-csi/csi-release-tools@a6a1a79 Merge kubernetes-csi/csi-release-tools#176 from pohly/go-1.17.3 kubernetes-csi/csi-release-tools@0a2cf63 prow.sh: bump Go to 1.17.3 kubernetes-csi/csi-release-tools@fc29fdd Merge kubernetes-csi/csi-release-tools#141 from pohly/prune-replace-optional kubernetes-csi/csi-release-tools@b46691a go-get-kubernetes.sh: make replace statement pruning optional git-subtree-dir: release-tools git-subtree-split: a6a1a79
master: update release-tools
…o ListSnapshots Signed-off-by: Joe Skazinski <joseph.skazinski@seagate.com>
…ot-secrets feat(ListSnapshotsSecret): csi-sanity test suite now passes secrets to ListSnapshots
kubernetes-csi/csi-release-tools@31aa44d Merge kubernetes-csi/csi-release-tools#182 from chrishenzie/csi-sanity-version kubernetes-csi/csi-release-tools@f49e141 Update csi-sanity test suite to v4.3.0 kubernetes-csi/csi-release-tools@d9815c2 Merge kubernetes-csi/csi-release-tools#181 from mauriciopoppe/armv7-support kubernetes-csi/csi-release-tools@05c1801 Add support to build arm/v7 images kubernetes-csi/csi-release-tools@4aedf35 Merge kubernetes-csi/csi-release-tools#178 from xing-yang/timeout kubernetes-csi/csi-release-tools@2b9897e Increase build timeout kubernetes-csi/csi-release-tools@51d3702 Merge kubernetes-csi/csi-release-tools#177 from mauriciopoppe/kind-image-1.23 kubernetes-csi/csi-release-tools@a30efea Add kind image for 1.23 git-subtree-dir: release-tools git-subtree-split: 31aa44d
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chrishenzie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Messed up base branch and having trouble editing, will remake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed 'release-tools/' changes from a6a1a79..31aa44d
31aa44d Merge pull request #182 from chrishenzie/csi-sanity-version
f49e141 Update csi-sanity test suite to v4.3.0
d9815c2 Merge pull request #181 from mauriciopoppe/armv7-support
05c1801 Add support to build arm/v7 images
4aedf35 Merge pull request #178 from xing-yang/timeout
2b9897e Increase build timeout
51d3702 Merge pull request #177 from mauriciopoppe/kind-image-1.23
a30efea Add kind image for 1.23
git-subtree-dir: release-tools
git-subtree-split: 31aa44d