dependency update #315
Merged
dependency update #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msau42
reviewed
Dec 14, 2020
hack/e2e.sh
Outdated
| runTestWithDifferentAddresses "${UDS_NODE}" "${UDS_CONTROLLER}" && | ||
| runTestAPIWithCustomTargetPaths "${UDS}" && | ||
| runTestWithCustomTargetPaths "${UDS}" "${UDS}" | ||
| #runTest "${TCP_SERVER}" "${TCP_CLIENT}" && |
There was a problem hiding this comment.
why are all these tests disabled?
There was a problem hiding this comment.
Ooops. Because I was manually testing a failing one (caused by the Ginkgo semantic change) and then I forgot to revert that temporary change. Will fix.
Done with `go get -u ./...` The newer Ginkgo change the semantic of Describe() so that the function callback only gets invoked sometime later, which is why we need to rebind the "test" loop variable.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
No particular reason other than pulling in potential bug fixes.
Does this PR introduce a user-facing change?: