remove obsolete mock driver #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver got replaced by an enhanced csi-driver-host-path. "make test-sanity" will now check out the csi-driver-host-path source, build it and run sanity testing as root. This is needed because in contrast to the mock driver, the csi-driver-host-path actually does bind mounts. Some special ways of testing a CSI driver (with credentials and different endpoints) don't get tested anymore because csi-driver-host-path does not support those modes of operation.
8a57e46 to
a4185b3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The driver got replaced by an enhanced csi-driver-host-path.
Which issue(s) this PR fixes:
Fixes kubernetes-csi/csi-driver-host-path#247
Special notes for your reviewer:
"make test-sanity" will now check out the csi-driver-host-path source, build it
and run sanity testing as root. This is needed because in contrast to the mock
driver, the csi-driver-host-path actually does bind mounts.
Some special ways of testing a CSI driver (with credentials and different
endpoints) don't get tested anymore because csi-driver-host-path does not
support those modes of operation.
Does this PR introduce a user-facing change?: