Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix travis check failure #2033

Closed
wants to merge 22 commits into from
Closed

[WIP] Fix travis check failure #2033

wants to merge 22 commits into from

Conversation

numerology
Copy link

@numerology numerology commented Sep 3, 2019 •
edited by jlewi
Loading

/hold

Duplicate of #2012

This change is Reviewable

ajchili and others added 19 commits September 1, 2019 11:30
@ajchili
Fix bug where source and variables are not accessible to visualization
a1ab88c
@ajchili
Updated snapshot
4a47cf8
@ajchili
Removed test_generate_test_visualization_html_from_notebook
0798ca4
@ajchili
Added test cases to ensure roc_curve, table, and tfdv visualizations …
5b0a55f 
…can be generated
@ajchili
Made test requirements identical to normal requirements
7f11c43
@ajchili
Fixed source links
eef0ac1
@ajchili
Updated test_server.py to use table visualization
38a667e
@IronPan @ajchili
Update .travis.yml
500b208
@ajchili
Add logging to debug travis tests
6f2df58
@ajchili
Add tensorflow back to requirements.txt
8841fc3
@ajchili
Updated .travis.yml and requirements.txt, also added comment that spe…
5da1796 
…cifies required libraries to run tests
@ajchili
Testing TFDV visualization with different source
7e9066f
@ajchili
Changed remote paths to be local due to timeout issues
4c90c42
@ajchili
Removed visualization tests due to continued failure
b961af5
@ajchili
Reverted .gitignore and removed tensorflow from text_exporter pip ins…
8970859 
…tall command
@ajchili
Moved where dependencies are installed in .travis.yaml
6d9295a
@ajchili
Revert "Made test requirements identical to normal requirements"
2276ed5 
This reverts commit 7f11c43.
@ajchili
Added pip install requirements to .travis file
d67ad52
Merge branch 'ajchili/fix-visualization-arguments-not-found-bug' of h…
b380472 
…ttps://github.com/ajchili/pipelines into fix-travis-check-failure
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ironpan
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Sep 3, 2019
@numerology
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@numerology: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@numerology numerology deleted the fix-travis-check-failure branch September 4, 2019 04:22
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun
Update lightgbm version (kubeflow#2033)
12bb6e8 
* Update lightgbm version

Signed-off-by: Dan Sun <dsun20@bloomberg.net>

* Remove image configs

Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees
No one assigned
Labels
do-not-merge/hold do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@numerology @k8s-ci-robot @googlebot @ajchili @IronPan