Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where source and variables are not accessible to visualization #2012

Merged
merged 21 commits into from
Sep 10, 2019
Merged

Fix bug where source and variables are not accessible to visualization #2012

merged 21 commits into from
Sep 10, 2019

Conversation

ajchili
Copy link
Member

@ajchili ajchili commented Aug 30, 2019 •
edited by jlewi
Loading

This change is Reviewable

@ajchili
Copy link
Member Author

ajchili commented Aug 30, 2019

/assign @IronPan @neuromage

@ajchili ajchili changed the title Fix bug where source and variables are not accessible to visualization Fix bug where source and variables are not accessible to visualization and add tests to prevent this from occurring again Aug 30, 2019
@IronPan
Copy link
Member

IronPan commented Aug 30, 2019

/lgtm
/approve

@ajchili
Copy link
Member Author

ajchili commented Aug 31, 2019

/hold
Still has logging used for testing.

@ajchili ajchili changed the title Fix bug where source and variables are not accessible to visualization and add tests to prevent this from occurring again Fix bug where source and variables are not accessible to visualization Aug 31, 2019
@ajchili ajchili force-pushed the ajchili/fix-visualization-arguments-not-found-bug branch from 9c69faf to 6d9295a Compare September 1, 2019 15:30
@ajchili
Copy link
Member Author

ajchili commented Sep 3, 2019

@numerology do you know why the unit test fails? It looks the Google Cloud package is not being installed by travis but I do not know why it is missing for my branch.

@numerology numerology self-assigned this Sep 3, 2019
@numerology numerology mentioned this pull request Sep 3, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ajchili
Copy link
Member Author

ajchili commented Sep 4, 2019

/hold cancel

@ajchili
Copy link
Member Author

ajchili commented Sep 5, 2019

/retest

@ajchili
Copy link
Member Author

ajchili commented Sep 6, 2019

ping @IronPan

@numerology
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 3726eb2 into kubeflow:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@neuromage neuromage Awaiting requested review from neuromage

Assignees

@neuromage neuromage

@IronPan IronPan

@numerology numerology

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajchili @IronPan @k8s-ci-robot @numerology @neuromage