Update lightgbm version (kubeflow#2033)

* Update lightgbm version Signed-off-by: Dan Sun <dsun20@bloomberg.net> * Remove image configs Signed-off-by: Dan Sun <dsun20@bloomberg.net>
magdalenakuhn17 · Feb 10, 2022 · 12bb6e8 · 12bb6e8
1 parent 7347e2f
commit 12bb6e8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 27 deletions.
diff --git a/config/overlays/test/configmap/inferenceservice.yaml b/config/overlays/test/configmap/inferenceservice.yaml
@@ -7,35 +7,25 @@ data:
   predictors: |-
     {
         "tensorflow": {
-            "image": "tensorflow/serving",
-            "defaultImageVersion": "1.14.0",
-            "defaultGpuImageVersion": "1.14.0-gpu",
-            "defaultTimeout": "60",
             "supportedFrameworks": [
              "tensorflow"
             ],
             "multiModelServer": false
         },
         "onnx": {
-            "image": "mcr.microsoft.com/onnxruntime/server",
-            "defaultImageVersion": "v1.0.0",
             "supportedFrameworks": [
               "onnx"
             ],
             "multiModelServer": false
         },
         "sklearn": {
           "v1": {
-            "image": "809251082950.dkr.ecr.us-west-2.amazonaws.com/kserve/sklearnserver",
-            "defaultImageVersion": "latest",
             "supportedFrameworks": [
               "sklearn"
             ],
             "multiModelServer": true
           },
           "v2": {
-            "image": "docker.io/seldonio/mlserver",
-            "defaultImageVersion": "0.5.3",
             "supportedFrameworks": [
               "sklearn"
             ],
@@ -44,42 +34,31 @@ data:
         },
         "xgboost": {
           "v1": {
-            "image": "809251082950.dkr.ecr.us-west-2.amazonaws.com/kserve/xgbserver",
-            "defaultImageVersion": "latest",
             "supportedFrameworks": [
               "xgboost"
             ],
             "multiModelServer": true
           },
           "v2": {
-            "image": "docker.io/seldonio/mlserver",
-            "defaultImageVersion": "0.5.3",
             "supportedFrameworks": [
               "xgboost"
             ],
             "multiModelServer": true
           }
         },
         "pytorch": {
-          "image": "kserve/torchserve-kfs",
-          "defaultImageVersion": "0.5.2",
-          "defaultGpuImageVersion": "0.5.2-gpu",
           "supportedFrameworks": [
             "pytorch"
           ],
           "multiModelServer": false
         },
         "paddle": {
-            "image": "ruminateer/paddleserver",
-            "defaultImageVersion": "v0.1.0",
             "supportedFrameworks": [
               "paddle"
             ],
             "multiModelServer": false
         },
         "triton": {
-            "image": "nvcr.io/nvidia/tritonserver",
-            "defaultImageVersion": "20.08-py3",
             "supportedFrameworks": [
               "tensorrt",
               "tensorflow",
@@ -90,16 +69,12 @@ data:
             "multiModelServer": true
         },
         "pmml": {
-            "image": "809251082950.dkr.ecr.us-west-2.amazonaws.com/kserve/pmmlserver",
-            "defaultImageVersion": "latest",
             "supportedFrameworks": [
               "pmml"
             ],
             "multiModelServer": false
         },
         "lightgbm": {
-            "image": "809251082950.dkr.ecr.us-west-2.amazonaws.com/kserve/lgbserver",
-            "defaultImageVersion": "latest",
             "supportedFrameworks": [
               "lightgbm"
             ],

diff --git a/pkg/apis/serving/v1beta1/inference_service_defaults.go b/pkg/apis/serving/v1beta1/inference_service_defaults.go
@@ -371,6 +371,8 @@ func (isvc *InferenceService) setMlServerDefaults() {
 	modelClass := constants.MLServerModelClassSKLearn
 	if isvc.Spec.Predictor.Model.ModelFormat.Name == constants.SupportedModelXGBoost {
 		modelClass = constants.MLServerModelClassXGBoost
+	} else if isvc.Spec.Predictor.Model.ModelFormat.Name == constants.SupportedModelLightGBM {
+		modelClass = constants.MLServerModelClassLightGBM
 	}
 	if isvc.ObjectMeta.Labels == nil {
 		isvc.ObjectMeta.Labels = map[string]string{constants.ModelClassLabel: modelClass}

diff --git a/pkg/constants/constants.go b/pkg/constants/constants.go
@@ -292,6 +292,7 @@ const (
 const (
 	MLServerModelClassSKLearn = "mlserver_sklearn.SKLearnModel"
 	MLServerModelClassXGBoost = "mlserver_xgboost.XGBoostModel"
+	MLServerModelClassLightGBM = "mlserver_lightgbm.LightGBMModel"
 )
 
 // torchserve service envelope label allowed values

diff --git a/python/lgbserver/setup.py b/python/lgbserver/setup.py
@@ -34,10 +34,9 @@
     packages=find_packages("lgbserver"),
     install_requires=[
         "kserve>=0.7.0",
-        "lightgbm == 2.3.1",
+        "lightgbm == 3.3.2",
         "pandas == 0.25.3",
         "argparse >= 1.4.0",
-        "numpy == 1.19.5",
     ],
     tests_require=tests_require,
     extras_require={'test': tests_require}