kustomize v3 manifest for argo, minio, mysql for both generic and gcp stack #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/assign @jlewi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jun 15, 2020
rmgogogo
reviewed
Jun 16, 2020
| #!/usr/bin/env bash | ||
|
|
||
| export PIPELINES_SRC_REPO=https://github.com/kubeflow/pipelines.git | ||
| export PIPELINES_VERSION=1.0.0-rc.1 |
There was a problem hiding this comment.
in the future for new version updates, we just
-
update this value
-
run this shell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: this was originally intended as a follow up PR of #1243 that only introduces mysql kustomize v3 manifest, but this was merged first including previous PRs' commits. Therefore, I renamed this PR to contain everything. In the future, I will apply hold label for PRs not ready for merge.
This merged PR included commits for: #1241 #1242 #1243
This is based on #1243, please merge it first.
This PR can be reviewed with https://github.com/kubeflow/manifests/pull/1247/files/6151fe9f4a0c48a8a256227232b3a31be7cca831..2544716e74fd18a27bb41b272f65546497c5fbf9 now.
Which issue is resolved by this Pull Request:
Resolves kubeflow/pipelines#3975
Description of your changes:
Mysql kustomize v3 manifest for both generic and gcp stack
Checklist:
cd manifests/testsmake generate-changed-onlymake test