-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argo to stacks/generic #1241
Conversation
/assign @jlewi |
Friendly ping @jlewi, can you review this? |
/lgtm |
/lgtm But looks like there are conflicts |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Bobgy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The mysql PR based on minio and argo PRs, but it was already merged first, so changes in this PR is already in master. |
Merged together in #1247 |
@Bobgy: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which issue is resolved by this Pull Request:
Follow up of #1185
Part of #1090
Description of your changes:
Add argo to
stacks/generic
Checklist:
cd manifests/tests
make generate-changed-only
make test