Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argo to stacks/generic #1241

Closed
wants to merge 1 commit into from
Closed

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 11, 2020

Which issue is resolved by this Pull Request:
Follow up of #1185
Part of #1090

Description of your changes:
Add argo to stacks/generic

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 11, 2020

/assign @jlewi

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 12, 2020

Friendly ping @jlewi, can you review this?
(it's the base for two other PRs, and more incoming, so I'd hope this one gets reviewed early)

@jlewi
Copy link
Contributor

jlewi commented Jun 12, 2020

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Jun 12, 2020

/lgtm
/approve

But looks like there are conflicts

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@Bobgy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit 1c43da3 link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 12, 2020

The mysql PR based on minio and argo PRs, but it was already merged first, so changes in this PR is already in master.
@jlewi Shall we revert it and merge in the correct order to get a cleaner commit history?
or we just close these already merged ones?

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 15, 2020

Merged together in #1247
/close

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closed this PR.

In response to this:

Merged together in #1247
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants