-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull kubeflow pipelines manifest from upstream using kpt #1242
Conversation
/assign @jlewi |
@@ -0,0 +1,9 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a doc for the pull action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use it ./hack/pull_kfp_upstream.sh
Anything else we'd want to document?
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Bobgy: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
NOTE: the branch is based on #1241, so please merge it first.
To review this PR, please look at https://github.com/kubeflow/manifests/pull/1242/files/1c43da3eeeb2883e4072bd0681c73fc9aeca2e75..3fa9d2194ed715d2c9c53014207bf47622315ce6
Which issue is resolved by this Pull Request:
Resolves kubeflow/pipelines#3962
Description of your changes:
Pull kubeflow pipelines manifest from upstream using kpt
Checklist:
cd manifests/tests
make generate-changed-only
make test