Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💅 collection max supply #8389

Merged
merged 2 commits into from
Dec 4, 2023
Merged

💅 collection max supply #8389

merged 2 commits into from
Dec 4, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Dec 4, 2023

Screenshot 2023-12-04 at 08-45-14 Snowflakes

@roiLeo roiLeo requested a review from a team as a code owner December 4, 2023 07:46
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team December 4, 2023 07:46
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit afd98cd
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656dc485f1c15600083c2b20
😎 Deploy Preview https://deploy-preview-8389--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 4, 2023
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 4, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 4, 2023

AI-Generated Summary: This pull request introduces the concept of maximum supply to the collection data. It adds a maxSupply data field in util types and uses these details in CollectionInfo.vue. Added a total supply information line to the collection information, with a conditional rendering based on the isAssetHub property. The possibility of an unlimited supply is also accounted for with the 'unlimited' text in locales/en.json. Furthermore, the 'max' field was added in collectionStatsById.graphql to retrieve the maximum supply data from the backend. In total, 11 lines of code were added, and 1 line was modified in 5 different files.

@roiLeo roiLeo mentioned this pull request Dec 4, 2023
Closed
6 tasks
@vikiival vikiival enabled auto-merge December 4, 2023 11:51
@prury prury self-requested a review December 4, 2023 12:15
@roiLeo @prury
Update components/collection/CollectionInfo.vue
afd98cd 
Co-authored-by: Ramo <36627808+prury@users.noreply.github.com>
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit afd98cd and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@prury
Copy link
Member

prury commented Dec 4, 2023

@roiLeo made a collection with limited supply and it still shows unlimited:

https://deploy-preview-8389--koda-canary.netlify.app/ahk/collection/289

image

@roiLeo
Copy link
Contributor Author

roiLeo commented Dec 4, 2023 •
edited
Loading

https://squid.subsquid.io/stick/graphql
Capture d’écran 2023-12-04 à 1 49 03 PM

works on https://deploy-preview-8347--koda-canary.netlify.app/ahk/collection/289 with #8347

did you set through Collection Creation page?

@vikiival vikiival mentioned this pull request Dec 4, 2023
Closed
1 task
@vikiival
Copy link
Member

vikiival commented Dec 4, 2023

Yes this is a known bug - reported by us about a month ago

@prury
Copy link
Member

prury commented Dec 4, 2023

https://squid.subsquid.io/stick/graphql Capture d’écran 2023-12-04 à 1 49 03 PM

works on https://deploy-preview-8347--koda-canary.netlify.app/ahk/collection/289 with #8347

did you set through Collection Creation page?

yup, you can see it on this transaction:
https://assethub-kusama.subscan.io/tx/0x5857c471c0d01240649b438ffc0b4d7d13facfb78d72c21a43d335d2a2d0350e

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 4, 2023
@AshutoshSingh00001
Copy link
Contributor

AshutoshSingh00001 commented Dec 4, 2023 •
edited
Loading

@roiLeo @prury @vikiival I had made a pull request for total supply in which @prury the issue you're facing dosen't appear I can see the supply clearly this is why @roiLeo I was not using indexer I got some bugs at the beginning so I used api which dosen't cause this #8347
deploy: https://deploy-preview-8347--koda-canary.netlify.app/ahk/collection/289
Screenshot 2023-12-04 at 7 40 52 PM

@vikiival vikiival mentioned this pull request Dec 4, 2023
Closed
@yangwao yangwao self-requested a review December 4, 2023 20:21
@vikiival vikiival added this pull request to the merge queue Dec 4, 2023
Merged via the queue into kodadot:main with commit be3b93d Dec 4, 2023
This was referenced Dec 7, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prury prury prury left review comments

@yangwao yangwao yangwao approved these changes

@vikiival vikiival vikiival approved these changes

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roiLeo @prury @vikiival @AshutoshSingh00001 @yangwao