Feat: Total Supply for AssetHubs #8346

[AshutoshSingh00001]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Total Supply for AssetHubs #8346
• ## Did your issue had any of the "$" label on it?
• My DOT address: Payout

[kodabot]

SUCCESS @AshutoshSingh00001 PR for issue #8346 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	18f04a9
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/656b99ef70f90e00082f0ba3
😎 Deploy Preview	https://deploy-preview-8347--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request introduces a new feature to the collection stat, "Total Supply", which provides the maximum supply of a collection. It extends the functionality into three different files to achieve this.

1. CollectionInfo.vue - This is where the Total Supply UI component is added. It will display the total available supply.

2. types.ts - The Stats type definition is expanded to include maxSupply, which can store a number or a string value.

3. useCollectionDetails.ts - Fetches the data from the API via api.query.nfts.collectionConfigOf(collectionId) and parses the response to extract maxSupply.

In total, there are 10 insertions and 1 deletion across these three files. The changes will provide additional statistical data to the user, enhancing overall usability and information availability.

[roiLeo]

please could you share a screenshot?
plus we don't need to call api since you can retrieve the data from indexer

[AshutoshSingh00001]

please could you share a screenshot? plus we don't need to call api since you can retrieve the data from indexer

I think it's a good idea to use indexer but it works the same and also by using api we get the same values and a lot of time api is used in many different places view #8346 for screenshots

[AshutoshSingh00001]

it works fine and is it necessary to use indexer if I have an option to use api as I saw on kodadot contributors.md indexer is preferred but api can also be used I had to get the value then convert it into Json format then call a specific object so I used it

[roiLeo]

please use indexer instead, it doesn't work on some collection (i.e. /ahk/collection/u-65535)

[AshutoshSingh00001]

please use indexer instead, it doesn't work on some collection (i.e. /ahk/collection/u-65535)

@roiLeo I already knew about this is why I didn't used indexer it is just for nft pallet not for uniques pallet u-65535 this is uniques collection

[AshutoshSingh00001]

please use indexer instead, it doesn't work on some collection (i.e. /ahk/collection/u-65535)

uniques is now depreciated https://wiki.polkadot.network/docs/learn-nft-pallets#uniques-pallet read this and we are moving to nft pallet

[roiLeo]

https://canary.kodadot.xyz/ahp/collection/30
vs
https://deploy-preview-8347--koda-canary.netlify.app/ahp/collection/30

your code throw error on empty collection

[AshutoshSingh00001]

u-65535

this is why other stats are also not showing like items and owners

[AshutoshSingh00001]

https://canary.kodadot.xyz/ahp/collection/30 vs https://deploy-preview-8347--koda-canary.netlify.app/ahp/collection/30

your code throw error on empty collection

@roiLeo got it

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codeclimate]

Code Climate has analyzed commit 18f04a9 and detected 0 issues on this pull request.

View more on Code Climate.

[AshutoshSingh00001]

https://canary.kodadot.xyz/ahp/collection/30 vs https://deploy-preview-8347--koda-canary.netlify.app/ahp/collection/30

your code throw error on empty collection

I fixed it but😂 that collection is destroyed and I think I should added destroy tag to destroyed collections

[AshutoshSingh00001]

@roiLeo genuinely your review is too good you gave me a link of destroyed collection this is why I used api which actually helps us to catch bugs

[AshutoshSingh00001]

@roiLeo changes are made can you review again

[roiLeo]

@roiLeo changes are made can you review again

please see #8389

[AshutoshSingh00001]

@roiLeo changes are made can you review again

please see #8389

sorry but this not fair I had took this issue first 🥲 so sad I'll no more contribute if this happens

[roiLeo]

sorry but this not fair I had took this issue first 🥲 so sad I'll no more contribute if this happens

I asked you to use indexer, still no changes just comments.

[AshutoshSingh00001]

sorry but this not fair I had took this issue first 🥲 so sad I'll no more contribute if this happens

I asked you to use indexer, still no changes just comments.

but here https://github.com/kodadot/nft-gallery/blob/main/content/blog/first-time.md we can use any of them it might be your personal demand but if it works properly and I saw api was used on several places so I used it if you think it's my fault ok it's fine I just lost 4 days on this pr at least now you told me your final review thanks

[AshutoshSingh00001]

@roiLeo thanks