Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set collection max supply via separate call #8391

Closed
1 task done
vikiival opened this issue Dec 4, 2023 · 4 comments · Fixed by #8919
Closed
1 task done

Set collection max supply via separate call #8391

vikiival opened this issue Dec 4, 2023 · 4 comments · Fixed by #8919
Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app

Comments

@vikiival
Copy link
Member

vikiival commented Dec 4, 2023 •
edited
Loading

What happened?

@prury found out in - #8389

@roiLeo made a collection with limited supply and it still shows unlimited:

https://deploy-preview-8389--koda-canary.netlify.app/ahk/collection/289

This is caused by a bug in Polkadot SDK - paritytech/polkadot-sdk#2293

and therefore we cannot pick it up in the indexer yet - kodadot/stick#147

Please reproduce in steps

  1. Create a collection on ah*
  2. Set max supply to any arbitrary number (1000)
  3. UI will not pick the number

Expected Behavior

Task

  1. remove the max from create() call
  2. if max is set append new call to the batch api.tx.nfts.setCollectionMaxSupply(id, max)
  3. Enjoy

Code of Conduct

  • I agree to follow this project's Code of Conduct
@vikiival vikiival added bug Something isn't working p2 core functionality, or is affecting 60% of app labels Dec 4, 2023
@vikiival vikiival mentioned this issue Dec 4, 2023
Merged
@vikiival vikiival added $ ~<50usd p1 preventing everyone from using app and removed p2 core functionality, or is affecting 60% of app labels Dec 4, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Dec 4, 2023 •
edited
Loading

alternative solution hotfix #8045

@roiLeo
Copy link
Contributor

roiLeo commented Dec 8, 2023

Meanwhile paritytech/polkadot-sdk@1bdfb29

@vikiival
Copy link
Member Author

vikiival commented Dec 8, 2023

@jsidorenko when can we expect release to ksm / dot?

@jsidorenko
Copy link

I have no idea.. usually, it takes 3 weeks to get released, although, for my last fix it took 6 months after I merged it to get onchain

This was referenced Jan 9, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
$ ~<50usd bug Something isn't working p1 preventing everyone from using app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Supply has been set but shows unlimited on collection page hassnian/nft-gallery
3 participants
@jsidorenko @roiLeo @vikiival